From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E8C095E0EF3; Tue, 12 Sep 2023 13:20:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E8C095E0EF3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1694514011; bh=8GFl43YtyOZiSSyupKypcyngPv9VoDXr9fbdf5uKKLg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=uLujMz0nZTzHirSCbXnVs5oTcDvxKJxBU5BoS3+cpw2pcUIpyAn14eKH4jwEfESVg l1XJVwCrambo4FpbK6uIilKpgAVvgwlDZ0UHM8evIRep9W2xeJvwQq6ijS8U0EibHC cn1fIVezPfiFkpZPw7Y8n/grO//sbQOgTV3WA0Vc= Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [95.163.41.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9BBE85E0EF3 for ; Tue, 12 Sep 2023 13:20:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9BBE85E0EF3 Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1qg0V6-007k8u-2q; Tue, 12 Sep 2023 13:20:09 +0300 Message-ID: <685a57df-a7e7-a1ab-aac0-6b4b64e24c8d@tarantool.org> Date: Tue, 12 Sep 2023 13:20:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: Sergey Kaplun Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com References: <272d18bd-5333-1224-31c3-8d59475f6afc@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD99D78F05E8BF27CBF33B4C3745E97D045ADC2ED4DA54B869ACD62213F67905E7ACBEBBC8E40EC1B5400E431ECBC0951CC31D8CB535F53269A08E1323863CD3BC3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DECE8D0A5E25C0FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373CF509324F67ED188638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8325CB817E92765032113D34DFFE8392B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACDC766E17BBE5724E9D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D88AD7EC71F1DB88427C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637217F7D133B16D230EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A54FAE083B5A903AA34327D875FD33420E36B452A93AEDFACFF87CCE6106E1FC07E67D4AC08A07B9B0B355ED1E20F5346ACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34411AA3F52B5778B6A66A023F9D8D452893AC57CF5B0E89C162AC7E953F42E3D77C2E34FC103C17B91D7E09C32AA3244C89E630765688B0A9DF1A15D88F5DEC10435BF7150578642FBAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojvAECSnWEGII+kPTp6jqkBA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769D8E30AF96E577430058353C3F62F55D87B0B9A7C4E99E59BEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2][v2] Fix embedded bytecode loader. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, On 9/11/23 11:45, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the fixes! > > On 07.09.23, Sergey Bronnikov wrote: >> Hi, Sergey >> >> >>> | "" >>> >>> Nit: use single quotes instead of double quotes if possible. >> Without context it is difficult to get what is line you talk about. >> >> As I see everything is fine with quotes in version on the branch. >> > I'm talking about the same line (got this version from the branch): > > | +local function basename(path) > | + return path:match("[^/]*$") > | +end Fixed. --- a/test/tarantool-tests/utils/tools.lua +++ b/test/tarantool-tests/utils/tools.lua @@ -10,7 +10,7 @@ function M.basedir(path)  end  function M.basename(path) -  return path:match("[^/]*$") +  return path:match('[^/]*$')  end  function M.profilename(name) >>> Nit: `[^/\\]` is better since it also covers Windows. >>> See >>> | local dirname = arg[0]:gsub('([^/\\]+)$', '') >>> Since we don't support Windows feel free to ignore. >>> >>>> +end >>>> + >>>> +local stdout_msg = 'Lango team' >>>> +local lua_code = ('print(%q)'):format(stdout_msg) >>>> +local fpath = os.tmpname() >>>> +local path_lua = ('%s.lua'):format(fpath) >>>> +local path_c = ('%s.c'):format(fpath) >>>> +local path_so = ('%s.so'):format(fpath) >>> Minor: I suppose it should be renamed to `path_shared`, since on macOS >>> they have the ".dyld" suffix for shared libs. Hence, we need to use the >>> suffix in format of the shared library name too. You may take some >>> inspiration from here [1]. >> Fixed. > Hmm, I don't see these updates on the branch [1]. Maybe you forgot to push > your local changes to the repository (*)? Right, I forgot to force-push ;( Force-pushed now. >>> Nit: Indent is 4 spaces instead of 2. >>> >>>> + return path:match('(.*' .. sep .. ')') or './' >>> It's better to mention that the pattern matching is greedy, so we match >>> until the last separator. >> >> Updated. > This is missing too (*). Added a comment. >