From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 16722441841 for ; Thu, 26 Mar 2020 01:28:23 +0300 (MSK) References: <6068a76d-c4ae-a848-11fa-4e818e5c6243@tarantool.org> From: lvasiliev Message-ID: <681d1dcf-3178-ec6d-11c8-c5dc6edcb9c5@tarantool.org> Date: Thu, 26 Mar 2020 01:28:21 +0300 MIME-Version: 1.0 In-Reply-To: <6068a76d-c4ae-a848-11fa-4e818e5c6243@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH LUAROCKS v2 0/2] Move a rocks options filter from tarantoolctl to luarocks List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy , alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org On 19.03.2020 1:12, Vladislav Shpilevoy wrote: > Hi! Thanks for the patchset! > > Generally the comments are the same as for the other rocks-related > patchset: > > - Add a @ChangeLog; > - Provide a description of the patchset in the cover-letter. What > was made, how, why? > > On 19/11/2019 09:52, Leonid wrote: >> https://github.com/tarantool/tarantool/issues/4629 >> https://github.com/tarantool/luarocks/tree/lvasiliev/gh-4629-add-chdir-to-make >> >> Changes in v2: >> - Move chdir before loading the rockspec file >> >> Leonid (2): >> Add the chdir option for make >> Add the tarantool options black list. Update help >> >> src/luarocks/cmd/help.lua | 15 +++++++++------ >> src/luarocks/cmd/make.lua | 22 ++++++++++++++++------ >> src/luarocks/util.lua | 25 ++++++++++++++++++++----- >> 3 files changed, 45 insertions(+), 17 deletions(-) >> Hi. Thanks for the review! New version of patchset with the corrections was sent. Sorry, in first time I forgot to send a patch with tarantoolctl changes. About testing: You can read help (tarantoolctl rocks help) and try something from new commands(build config download init lint new_version purge which write_rockspec) For example: tarantoolctl rocks download xavante Or test some from breaking flags: For example: tarantoolctl rocks search --all