From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6A2EB46971A for ; Sat, 14 Dec 2019 19:49:56 +0300 (MSK) References: <20191210083258.GD21413@atlas> <2c8fe897-9a9d-849d-463e-5fadff982b8c@tarantool.org> <20191211070830.GA5953@atlas> <20191212084603.GA24448@atlas> <96368326-84a1-0b3c-15f8-54e3d044db85@tarantool.org> <20191213075850.GA21575@atlas> <60d9ec76-50be-ecae-175c-520975c928f9@tarantool.org> <20191214122644.GA17689@atlas> <20191214123056.GB17689@atlas> <20191214123333.GC17689@atlas> From: Vladislav Shpilevoy Message-ID: <67adef62-9767-06f0-32c5-53baa6ad491f@tarantool.org> Date: Sat, 14 Dec 2019 17:49:54 +0100 MIME-Version: 1.0 In-Reply-To: <20191214123333.GC17689@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov , tarantool-patches@dev.tarantool.org Well, I still don't understand what you are keep saying and what do you want, and since it does not look like I will, I am out of this ticket. On 14/12/2019 13:33, Konstantin Osipov wrote: > * Konstantin Osipov [19/12/14 15:30]: >> I checked now, and Lua addeded debug.getupvalue() to Lua C API. >> >> On other words, fiber storage now can be implemented in pure Lua, >> without any triggers. >> >> Back when we were writing, upvalue API was only available in C >> API, and AFAIR there was no way to access upvalues from Lua, this >> is why we had to come up with this hack. > > The feature can actually be deprecated. There is now a completely > legitimate and easy to use way to have a request-local object with > a user defined destructor in pure Lua. > > If you do want to keep it, you should try to minimized the damage > to the core, not extend it. >