From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <georgy@tarantool.org>
From: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= <georgy@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH v3 06/14] txn: get rid of fiber_gc from txn_rollback
Date: Thu, 13 Jun 2019 22:28:24 +0300
Message-ID: <6794812.AW9IRRbO8A@home.lan>
In-Reply-To: <20190613141256.vktkk4qea4wyock4@esperanza>
References: <cover.1560112747.git.georgy@tarantool.org> <95ba261a4768ec78f5e94596cdeb215ee1068cc2.1560112747.git.georgy@tarantool.org> <20190613141256.vktkk4qea4wyock4@esperanza>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart22302430.jgGl33cBnG"; micalg="pgp-sha256"; protocol="application/pgp-signature"
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

--nextPart22302430.jgGl33cBnG
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Thursday, June 13, 2019 5:12:56 PM MSK Vladimir Davydov wrote:
> On Sun, Jun 09, 2019 at 11:44:35PM +0300, Georgy Kirichenko wrote:
> > Don't touch a fiber gc storage on a transaction rollback explicitly.
...
> 
> As I wrote earlier, I'm pretty convinced we don't need to call
> fiber_gc() after txn_commit/rollback at all. Please consider
> removing it in a separate patch.
I call fiber_gc in such cases only in order to preserve the previous behavior. 
I think we could remove fiber_gc when all transaction data would be placed onto 
transaction memory. We could talk about f2f

--nextPart22302430.jgGl33cBnG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEFB+nbqWGnp59Rk9ZFSyY70x8X3sFAl0Co9gACgkQFSyY70x8
X3tdCwf/YL4u8lRfFISuMO6vK9gwC0UCHKmCHC7u8STSbPj0TgU5AigNuEaTTPVg
OZSzirx/ucZ9degs6llCYrxxDI3teurlw0mVkaQsfK3PHoRLn9HmoxpXAhsta67u
YW1ALvR8WdkGaIUZQ1426g6kXyWdhjB7P9X/Ug8hyRNKYI/PqpQpMB8coWELBK/H
FLn5uDP2J4j2WtognluW0oPMriYIilYTA1Snk3IMy1NYmlfohpUrrrXz9y1/UXDa
hOvubKAgK9rLADbdgLwzRlJEvqZdx0siftmcOcre6AKjnR/flRgqPFahIovMdWD8
wjK3HKVolHzDNsDwz/yXFc98wjccEQ==
=eboH
-----END PGP SIGNATURE-----

--nextPart22302430.jgGl33cBnG--