From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D174CE34C62; Mon, 13 Jan 2025 17:29:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D174CE34C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1736778590; bh=8xy3Z9t0oacpR5vY7t/umIFxFz7q/p86W6B0ICZL6e0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ZNR6vxiRzzRWmnwUWRIzvFpyz3XqKX1p64K+u7+mIWNQTEfwaqMtPOnZ9MGQPf1G7 KexyYOgM/0FXcs7jJZvQU2vQA5eNmRfIlpy2RRrKd7BBQeIQIU1x3I42voMucoRqVS 2bi1Y0VAkVTqN8uDlsk3sjjDx7FzZJ11cjS0mdQI= Received: from send83.i.mail.ru (send83.i.mail.ru [89.221.237.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 59B9643D1A9 for ; Mon, 13 Jan 2025 17:29:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 59B9643D1A9 Received: by exim-smtp-bcf9586c5-2q6xc with esmtpa (envelope-from ) id 1tXLRt-00000000Fy2-1be4; Mon, 13 Jan 2025 17:29:49 +0300 Content-Type: multipart/alternative; boundary="------------btbFAjIl320mZzP4nLl9nFq7" Message-ID: <6771e492-e165-4148-bf78-e76cdde34ef2@tarantool.org> Date: Mon, 13 Jan 2025 17:29:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <20250109150124.23841-1-skaplun@tarantool.org> <847b75f4-07a9-4c99-83b1-d9833197a82d@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9FE29E411368906F797F5421AD5CD452FD2B8B9A5A3758EC8182A05F5380850404C228DA9ACA6FE2710BF2262C8EE522B3DE06ABAFEAF6705561E3F30931F87822A025081957A6C767821E8BEC7DEA809 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B264C8851FD8E810EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637652CD06254D2F21C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CB6106F20C8883E5571C1CA22B72587C4B92865D1545A71ECC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CAD0E433DBF1FBFA39735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C391041352CAA6A1D7BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE73A6989AD488FD87D731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5EAD7484B493541DF5002B1117B3ED6964F7AB1E103FDD633E41E333F9D1358D5823CB91A9FED034534781492E4B8EEAD14747542773C033FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D341776B9FDE05FBA7AA2B0083DD96071AE16DF69D11FD667F83DD1157236C6BDE252903C158E13F82E1D7E09C32AA3244CD897579254FA0AFD77DD89D51EBB77422D428604ACB5E5ABEA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtuBC1linLchXHUc4RY9lmw== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61401F7155B8417A6DD3411046492FDDF80634A1486678EE82FE0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix predict_next() in parser (for real now). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------btbFAjIl320mZzP4nLl9nFq7 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10.01.2025 14:10, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review. > > On 10.01.25, Sergey Bronnikov wrote: >> Hi, Sergey, >> >> thanks for the patch! >> >> test is passed with reverted patch. >> >> With original reproducer luajit segfaults. >> >> CMake options:  cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug >> -DLUA_USE_APICHECK=ON -DLUA_USE_ASSERT=ON > You must run this test with Valgrind enabled to see the failure as it is > mentioned in the commit. cmake arguments required for reproducing a bug by proposed test:  cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_APICHECK=ON -DLUA_USE_ASSERT=ON -DLUAJIT_USE_VALGRIND=ON -DLUAJIT_ENABLE_GC64=ON -DLUAJIT_USE_SYSMALLOC=ON > The original reproducer is clumsy and unstable > -- any slight change of the parser may break it. This reproducer is much > simpler, robust, and more readable. > >> >> Sergey >> >> On 09.01.2025 18:01, Sergey Kaplun wrote: > > >>> +-- The parsing of the `for` iterator uses the incorrect check for >>> +-- `fs->bclim`, which allows the usage of an uninitialized value, >>> +-- so the test fails under Valgrind. > > --------------btbFAjIl320mZzP4nLl9nFq7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 10.01.2025 14:10, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review.

On 10.01.25, Sergey Bronnikov wrote:

Hi, Sergey,

thanks for the patch!

test is passed with reverted patch.

With original reproducer luajit segfaults.

CMake options:  cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug 
-DLUA_USE_APICHECK=ON -DLUA_USE_ASSERT=ON

You must run this test with Valgrind enabled to see the failure as it is
mentioned in the commit.


cmake arguments required for reproducing a bug by proposed test:

 cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_APICHECK=ON -DLUA_USE_ASSERT=ON -DLUAJIT_USE_VALGRIND=ON -DLUAJIT_ENABLE_GC64=ON -DLUAJIT_USE_SYSMALLOC=ON


The original reproducer is clumsy and unstable
-- any slight change of the parser may break it. This reproducer is much
simpler, robust, and more readable.



Sergey

On 09.01.2025 18:01, Sergey Kaplun wrote:

<snipped>


+-- The parsing of the `for` iterator uses the incorrect check for
+-- `fs->bclim`, which allows the usage of an uninitialized value,
+-- so the test fails under Valgrind.

<snipped>
--------------btbFAjIl320mZzP4nLl9nFq7--