From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7731250B008; Thu, 13 Jul 2023 15:12:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7731250B008 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689250326; bh=9JBqEf0eaW4yBeKWshbA47CUbAh3M7w+lCaFIiEo1kg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=CMOL548s2kZfgHgncbmvMG++WfXVKyxAcklO22PHwSYDH1azdMN2tLpOkQYZ+O0WM uDH7DNcLYgSxf9gjL+5Gy0J+qp2nLIMVucsobyIG3rkgy1WtGJ97LO8FEcsFo5ax// M9FGyrueeJGPQZZPrfDaa8+yp60Bo4Ab/vFbEg9Y= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [95.163.41.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 371BD4F62AF for ; Thu, 13 Jul 2023 15:12:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 371BD4F62AF Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1qJvAy-00DY2C-7l; Thu, 13 Jul 2023 15:12:04 +0300 Message-ID: <67552873-63f9-b5af-bd8b-d8c54dcdfc74@tarantool.org> Date: Thu, 13 Jul 2023 15:12:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Igor Munkin , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <14eab2dd6a619fb33d9b82bd24b4c2515184659d.1689195028.git.imun@tarantool.org> In-Reply-To: <14eab2dd6a619fb33d9b82bd24b4c2515184659d.1689195028.git.imun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD90D3A2D5CD15493BE5FC25CDDA03C1C841FDE3111F33A20A0182A05F5380850404C228DA9ACA6FE276625B179931383E7B73977BE23E3672694780C1F97295F7142F70D4460B34B7D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063766C9C3EB94AE7C6E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DB33EB314ADB4714E7738A4AA9E1BFF3117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520902A1BE408319B2928451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE26055571C92BF10F287C8E22D4AE2A51D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE32D01283D1ACF37BA302FCEF25BFAB345C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C062BEEFFB5F8EA3E2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16BA91E23F1B6B78B78B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5B7FD86A9E312E04B431BF636175FA35793151FAFC8E44312F87CCE6106E1FC07E67D4AC08A07B9B0A6C7FFFE744CA7FBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340297C696F996E384CA65801B58A17F374C5784ED9C2ED1F9B40E11CF66CCB86E77E75B35D2EB269A1D7E09C32AA3244C831342990BBFC30785CD875F01E6A882250262A5EE9971B085A42E4C463514DC5DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmIyQFW4pVcnIqWPF57YRuA== X-Mailru-Sender: 49D287FBCBBF3A5C1746B9497B71E89E38BCC9C33CC70275B73977BE23E36726FE5F7FEA15315F16EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: introduce testing workflow with sanitizers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! LGTM with minor comments below Sergey On 7/13/23 00:09, Igor Munkin wrote: > This commit adds GitHub workflow running all available LuaJIT tests with > LUAJIT_USE_ASAN option enabled. For now, sanitizers workflow works only > for Linux/x86_64 as the most scaling setup in our CI. I believe we will > be able to add other platforms being supported, when ARM64 and macOS beware that ARM64 is absent in a list of supported platforms [1] https://clang.llvm.org/docs/AddressSanitizer.html#supported-platforms > + - name: test > + env: > + # Enable as much checks as possible. See more info here: However, some checks are *disabled*, for example "print_suppressions" and "heap_profile" are disabled. Is it intentionally? > + # https://github.com/google/sanitizers/wiki/AddressSanitizerFlags there are also LeakSanitizer flags here https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizer#flags > + ASAN_OPTIONS: " \ > + detect_invalid_pointer_pairs=1: \ > + detect_leaks=1: \ > + detect_stack_use_after_return=1: \ > + dump_instruction_bytes=1: \ > + heap_profile=0: \ > + print_suppressions=0 \ > + symbolize=1: \ > + unmap_shadow_on_exit=1: \ > + " > + run: cmake --build . --parallel --target LuaJIT-test > + working-directory: ${{ env.BUILDDIR }}