From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BBBBF296DB for ; Tue, 21 Aug 2018 12:31:26 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ALRGLu7HSp1a for ; Tue, 21 Aug 2018 12:31:26 -0400 (EDT) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 73F8F29359 for ; Tue, 21 Aug 2018 12:31:26 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH 07/10] sql: remove index type from struct Index From: "n.pettik" In-Reply-To: Date: Tue, 21 Aug 2018 19:31:25 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <67537FAC-C69C-4084-8EC7-7DBA87F802C0@tarantool.org> References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy > On 13 Aug 2018, at 23:24, Vladislav Shpilevoy = wrote: >=20 > Thanks for the patch! I have pushed my review fixes in > a separate commit. >=20 > The most significant change - I have inlined sql_index_is_unique > since index's is_unique flag is intuitive enough to understand > what is being checked. >=20 > Also I have reduced primary index getting to just returning > of the first index in pTable->pIndex list like it is done in > struct space. And this patch passes the tests. Actually, tests fail within this patch. I don=E2=80=99t think that this fix worth investigation: I have already removed struct Index and now hold indexes in table->space->index and always get PK as table->space->index[0]. Patch is on its way. > But next started > failing. Please, investigate why. Looks like you started > inserting primary index not in the list head.