From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 91F33D4E466; Fri, 1 Nov 2024 15:51:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 91F33D4E466 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1730465463; bh=MggSZQ7Xz5YfK2pmMKTZgnnZ2W5lkZKTepJJ97o3D8I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=e2/cairywrTbKIW/v8vWL/fNbSBaO/0QusXILQgiLOLXcHxSssUX1+fESwsfMNRWz Kv1x7Pzui+rM1YCndkvTdEVHRK7PfC1wpHvm6XZH5pX3Q6YbXBtxFnvnN9OSOwAkvw RKn9qovY+ATDkhE9X7mLWa1Fku8CsmBZvTInndpQ= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [95.163.41.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4308FD4E463 for ; Fri, 1 Nov 2024 15:51:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4308FD4E463 Received: by exim-smtp-6c5957b6dd-99jxc with esmtpa (envelope-from ) id 1t6r7F-000000005sx-1SIA; Fri, 01 Nov 2024 15:51:01 +0300 Content-Type: multipart/alternative; boundary="------------7FKErSO135JGgeSHkIyrWlNM" Message-ID: <666a32d8-deec-49a5-8b7f-80b8b86ed128@tarantool.org> Date: Fri, 1 Nov 2024 15:51:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: mandesero@gmail.com, tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org References: <20240918085053.150351-1-mandesero@gmail.com> In-Reply-To: <20240918085053.150351-1-mandesero@gmail.com> X-Mailru-Src: smtp X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92733C19FC6DB0C8B89B720F7715AEC6126967C1939315C7B182A05F5380850407858315316C177073DE06ABAFEAF6705694BAD29F63BC4F1FF139062A4A4C7AF9C45B5B3EE0679D2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BA0D57D3459E5640EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374A24022C550661178638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D820D0B21A43A90354D89BE2759593F7A070A53D905A5C04BACC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C6089696B24BB1D199735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C39E5FF5549954B0F1BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166176DF2183F8FC7C04E672349037D5FA5725E5C173C3A84C3CDD845A7E6742F4735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5966A94CE485460925002B1117B3ED6969BA2F6A28FD02935B48B7A7F94616420823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF24E2EEF04C5DDAD1B149947DEB8CAF54C8416E2728E711E1533300FD36B05366257E6C4F5EEB673E02643FFCD63D2E182BEE51CC3A751A0E4054AD264266FB7B62B8015157F4AFFDC226CC413062362A913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfMbdV4AJnq57cM1UbugTWQ== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140FF6975BD85A8BA1FD27678DDAA8063145BBB526ACF16356F0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 luajit 0/2] Enable running tests with Valgrind, add CI Valgrind testing workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------7FKErSO135JGgeSHkIyrWlNM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Maxim! thanks for new iteration! Please see my comments. On 18.09.2024 11:50, mandesero--- via Tarantool-patches wrote: > From: Maksim Tyushev > > This patchset enables running LuaJIT tests under Valgrind, with the > option to set custom Valgrind options using the `VALGRIND_OPTIONS` > environment variable. Please note that this environment variable must > be set before building, and any updates to it will require a project > rebuild. The patchset also introduces a Valgrind testing workflow > with three scenarios: full checks, and two memory checks without leak > detection, where memory is filled with `0x00` and `0xff`. > > Some tests consistently fail under Valgrind due to various reasons, > such as SIGPROF, timeouts, or flaky behavior. These tests are s/SIGPROF/sysprof/? > disabled when `LUAJIT_USE_VALGRIND=ON`. > > Branch:https://githb.com/tarantool/luajit/tree/mandesero/lj-3705-turn-off-strcmp-opt-in-debug > Issue:https://github.com/tarantool/tarantool/issues/3705 > > Changes in v3: > - Squashed commits 'run tests with Valgrind (1/3 v2)' and > 'disable failed tests (3/3 v2)'. > - Simplified `.github/actions/setup-valgrind`, now dependents > on `.github/actions/setup-linux`. > - Updated `test/CMakeLists.txt` with minor adjustments. > > Maksim Tiushev (2): > cmake: run tests with Valgrind > ci: add Valgrind testing workflow > > .github/actions/setup-valgrind/README.md | 12 +++ > .github/actions/setup-valgrind/action.yml | 12 +++ > .github/workflows/valgrind-testing.yaml | 95 +++++++++++++++++++ > CMakeLists.txt | 5 + > test/CMakeLists.txt | 16 ++++ > test/tarantool-tests/CMakeLists.txt | 3 +- > ...4-add-proto-trace-sysprof-default.test.lua | 1 + > .../gh-7745-oom-on-trace.test.lua | 1 + > .../lj-1034-tabov-error-frame.test.lua | 1 + > .../lj-512-profiler-hook-finalizers.test.lua | 4 +- > .../lj-726-profile-flush-close.test.lua | 4 +- > .../misclib-sysprof-lapi.test.lua | 1 + > 12 files changed, 152 insertions(+), 3 deletions(-) > create mode 100644 .github/actions/setup-valgrind/README.md > create mode 100644 .github/actions/setup-valgrind/action.yml > create mode 100644 .github/workflows/valgrind-testing.yaml > --------------7FKErSO135JGgeSHkIyrWlNM Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Maxim!

thanks for new iteration!

Please see my comments.

On 18.09.2024 11:50, mandesero--- via Tarantool-patches wrote:
From: Maksim Tyushev <mandesero@gmail.com>

This patchset enables running LuaJIT tests under Valgrind, with the
option to set custom Valgrind options using the `VALGRIND_OPTIONS`
environment variable. Please note that this environment variable must
be set before building, and any updates to it will require a project
rebuild. The patchset also introduces a Valgrind testing workflow
with three scenarios: full checks, and two memory checks without leak
detection, where memory is filled with `0x00` and `0xff`.

Some tests consistently fail under Valgrind due to various reasons,
such as SIGPROF, timeouts, or flaky behavior. These tests are
s/SIGPROF/sysprof/?
disabled when `LUAJIT_USE_VALGRIND=ON`.

Branch: https://githb.com/tarantool/luajit/tree/mandesero/lj-3705-turn-off-strcmp-opt-in-debug
Issue: https://github.com/tarantool/tarantool/issues/3705

Changes in v3:
 - Squashed commits 'run tests with Valgrind (1/3 v2)' and
   'disable failed tests (3/3 v2)'.
 - Simplified `.github/actions/setup-valgrind`, now dependents
   on `.github/actions/setup-linux`.
 - Updated `test/CMakeLists.txt` with minor adjustments.

Maksim Tiushev (2):
  cmake: run tests with Valgrind
  ci: add Valgrind testing workflow

 .github/actions/setup-valgrind/README.md      | 12 +++
 .github/actions/setup-valgrind/action.yml     | 12 +++
 .github/workflows/valgrind-testing.yaml       | 95 +++++++++++++++++++
 CMakeLists.txt                                |  5 +
 test/CMakeLists.txt                           | 16 ++++
 test/tarantool-tests/CMakeLists.txt           |  3 +-
 ...4-add-proto-trace-sysprof-default.test.lua |  1 +
 .../gh-7745-oom-on-trace.test.lua             |  1 +
 .../lj-1034-tabov-error-frame.test.lua        |  1 +
 .../lj-512-profiler-hook-finalizers.test.lua  |  4 +-
 .../lj-726-profile-flush-close.test.lua       |  4 +-
 .../misclib-sysprof-lapi.test.lua             |  1 +
 12 files changed, 152 insertions(+), 3 deletions(-)
 create mode 100644 .github/actions/setup-valgrind/README.md
 create mode 100644 .github/actions/setup-valgrind/action.yml
 create mode 100644 .github/workflows/valgrind-testing.yaml
--------------7FKErSO135JGgeSHkIyrWlNM--