Hi, Maxim! thanks for new iteration! Please see my comments. On 18.09.2024 11:50, mandesero--- via Tarantool-patches wrote: > From: Maksim Tyushev > > This patchset enables running LuaJIT tests under Valgrind, with the > option to set custom Valgrind options using the `VALGRIND_OPTIONS` > environment variable. Please note that this environment variable must > be set before building, and any updates to it will require a project > rebuild. The patchset also introduces a Valgrind testing workflow > with three scenarios: full checks, and two memory checks without leak > detection, where memory is filled with `0x00` and `0xff`. > > Some tests consistently fail under Valgrind due to various reasons, > such as SIGPROF, timeouts, or flaky behavior. These tests are s/SIGPROF/sysprof/? > disabled when `LUAJIT_USE_VALGRIND=ON`. > > Branch:https://githb.com/tarantool/luajit/tree/mandesero/lj-3705-turn-off-strcmp-opt-in-debug > Issue:https://github.com/tarantool/tarantool/issues/3705 > > Changes in v3: > - Squashed commits 'run tests with Valgrind (1/3 v2)' and > 'disable failed tests (3/3 v2)'. > - Simplified `.github/actions/setup-valgrind`, now dependents > on `.github/actions/setup-linux`. > - Updated `test/CMakeLists.txt` with minor adjustments. > > Maksim Tiushev (2): > cmake: run tests with Valgrind > ci: add Valgrind testing workflow > > .github/actions/setup-valgrind/README.md | 12 +++ > .github/actions/setup-valgrind/action.yml | 12 +++ > .github/workflows/valgrind-testing.yaml | 95 +++++++++++++++++++ > CMakeLists.txt | 5 + > test/CMakeLists.txt | 16 ++++ > test/tarantool-tests/CMakeLists.txt | 3 +- > ...4-add-proto-trace-sysprof-default.test.lua | 1 + > .../gh-7745-oom-on-trace.test.lua | 1 + > .../lj-1034-tabov-error-frame.test.lua | 1 + > .../lj-512-profiler-hook-finalizers.test.lua | 4 +- > .../lj-726-profile-flush-close.test.lua | 4 +- > .../misclib-sysprof-lapi.test.lua | 1 + > 12 files changed, 152 insertions(+), 3 deletions(-) > create mode 100644 .github/actions/setup-valgrind/README.md > create mode 100644 .github/actions/setup-valgrind/action.yml > create mode 100644 .github/workflows/valgrind-testing.yaml >