From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9AB852A78E for ; Thu, 21 Mar 2019 11:23:38 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nv8ies9WGSQh for ; Thu, 21 Mar 2019 11:23:38 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1903A2634E for ; Thu, 21 Mar 2019 11:23:38 -0400 (EDT) From: "n.pettik" Message-Id: <664503E3-9B26-46D1-87DC-1FE1EEB97C90@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_A3B2C57F-B965-4884-A929-6AC7142CEE18" Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH v2 3/9] box: fix Tarantool upgrade from 2.1.0 to 2.1.1 Date: Thu, 21 Mar 2019 18:23:35 +0300 In-Reply-To: <628af1ea-16b5-b805-016a-05d7a6866944@tarantool.org> References: <1e4434445b60b5a5e0c3b289505595b0e00c8f8c.1548838034.git.kshcherbatov@tarantool.org> <4F67EA78-E237-4424-BEF6-ECE8ADCD5CBF@tarantool.org> <860C81EF-4B1E-4648-A638-C804DB32A3EF@tarantool.org> <628af1ea-16b5-b805-016a-05d7a6866944@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Kirill Yukhin , Konstantin Osipov --Apple-Mail=_A3B2C57F-B965-4884-A929-6AC7142CEE18 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Guys, please, don=E2=80=99t ignore this patch. It is vital for 2.1.1 = release. > On 20 Mar 2019, at 18:38, Kirill Shcherbatov = wrote: >>>> Tarantool could not start from the snapshot created by version >>>> 2.1.0 because the new version 2.1.1 does not support the >>>> index.opts.sql index opt and stops the execution. >>>> Introduced a special state OPT_DEF_LEGACY macro to ignore legacy >>>> options and introduced migration code in upgrade.lua. >>>=20 >>> As for me, it looks satisfying, but I strongly recommend you to ask >>> other members of server team for comments on this approach. >>> Will there be other =E2=80=9Clegacy=E2=80=9D options, or in the = nearest future this is >>> going to be the only one? Moreover, opts_parse_key already features >>> =E2=80=9Cskip_unknown_options=E2=80=9D param - could we skip = =E2=80=9Csql=E2=80=9D option using it >>> (ofc considering some workaround)? >>>=20 >>> Again, since it is not directly related to the main patch-set, = let=E2=80=99s >>> consider it as independent.=20 >>=20 >> LGTM. >=20 > I've rebased this separate patch on the branch=20 > kshch/migration-fixup > you may cherry-pick it if it is really reasonable. --Apple-Mail=_A3B2C57F-B965-4884-A929-6AC7142CEE18 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Guys,= please, don=E2=80=99t ignore this patch. It is vital for 2.1.1 = release.

On 20 Mar 2019, at 18:38, = Kirill Shcherbatov <kshcherbatov@tarantool.org> wrote:
Tarantool could not = start from the snapshot created by version
2.1.0 because = the new version 2.1.1 does not support the
index.opts.sql = index opt and stops the execution.
Introduced a special = state OPT_DEF_LEGACY macro to ignore legacy
options and = introduced migration code in upgrade.lua.

As for me, it looks satisfying, but I strongly recommend you = to ask
other members of server team for comments on this = approach.
Will there be other =E2=80=9Clegacy=E2=80=9D = options, or in the nearest future this is
going to be the = only one? Moreover, opts_parse_key already features
=E2=80=9Cskip_unknown_options=E2=80=9D param - could we skip = =E2=80=9Csql=E2=80=9D option using it
(ofc considering = some workaround)?

Again, since it is not = directly related to the main patch-set, let=E2=80=99s
consider it as independent. 

LGTM.

I've rebased this separate patch on the branch 
kshch/migration-fixup
you may cherry-pick it if it is = really reasonable.

= --Apple-Mail=_A3B2C57F-B965-4884-A929-6AC7142CEE18--