From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4F1EC469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  7 Oct 2020 01:12:55 +0300 (MSK)
References: <cover.1601729099.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <6643130f-6b57-7c15-fb79-4bdd4873f561@tarantool.org>
Date: Wed, 7 Oct 2020 00:12:53 +0200
MIME-Version: 1.0
In-Reply-To: <cover.1601729099.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert
	operation
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patchset!

Does this patchset change format of vinyl statements on disk? If yes, I guess
it breaks backward compatibility. Did you check how does it behave when booted
from files of a previous version? Does it crash? Does it report an error? How
a user can upgrade his vinyl files to the new format?