From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 621866E200; Sat, 19 Jun 2021 01:58:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 621866E200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624057086; bh=kP1kP4DYNAfAd4v1Pexo9GNzGYv2iJqrtme5lCIDcww=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=UStoh6IJCeqeBj88oYzJcjR5jtqQxBYQKyuGY0KjWsnHJ0tJ2UP27LZ6e6TxL/rDe ndkD2m7G/JTfOh/osHc7K2XhnbuXs5yHev4HUrvutueJ3Ojgrdv6E9CUSx6DKpEcnC YYNvKyBz46N4Yv/Qf/auLjdPvoFG5UhB42iuiWJg= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CA0016E200 for ; Sat, 19 Jun 2021 01:58:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CA0016E200 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1luNR6-0007X8-6W; Sat, 19 Jun 2021 01:58:04 +0300 To: Cyrill Gorcunov Cc: tml References: <20210615135630.63465-1-gorcunov@gmail.com> <3a60e5a6-ef92-2e30-c5e8-7e0db70728ea@tarantool.org> Message-ID: <657ec5d8-63e1-25e2-171e-f2ef862ad844@tarantool.org> Date: Sat, 19 Jun 2021 00:58:03 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91C2C07775F13263A612E9F961DCF5576EBB1C736C2A4021700894C459B0CD1B9A18F84A3EA527CD70AB9B5609A68A0DCADAE08C9C8D3C36E261E30AE1A3D8EFE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE751DD1FEBB966604DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637829D9538242026C38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81CD7F0AC94CAD29A44D4B1A2134F4CDC117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCEA77C8EAE1CE44B0A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D56369A3576CBA5089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978318FF86DED4D49A75F2D680659EFB54793 X-C1DE0DAB: 0D63561A33F958A597A83E9A2F53AF2EE46CB624E80BD85BD074EA1124D540E6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A9A0A0BF1A2CAC6266F5C693820B4F97F36357CBAA1956EF5D07DD0F866D0A7D4EC06DD09E7AB1F41D7E09C32AA3244C120E682DB69780484D55DE997071392AE646F07CC2D4F3D8729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0Roc5o5ut96rXcvogPMz0A== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638228C318C7BA9B9C05593075CF5DE7F02B03841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v9 0/1] applier: filter incoming synchro packets via transaction initiator X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" >>> +box.cfg{replication = {require('fio').cwd() .. "/replica1.sock"}} >> >> 2. You don't need require('fio').cwd(). "unix/:./replica1.sock" works >> just fine. The same for the other socket paths. > > Actually I too this from other examples since I suspect the use of > absolute path might be critical for test run engine. It is not a problem > to rename but other our tests do use this trick so meaybe we should stick > with same approach? Again, I don't mind to use relative path if this > won't cause problems in future. Cargo cult does not work. If something is done somewhere, it does not mean it is correct. I see no issues with using the relative path. Anyway if it won't work someday, your way won't either, because cwd() is the same as "./". >>> +-- Make the master to be RAFT leader, this drops connection >>> +-- to the replica2. >> >> 3. There was no connection to replica2 from master. >> > > I'll update the comment, thanks! (actually replica2 > connected to the master initialy and this is full > duplex connection which we close on reconfig, that's > what I meant saying "dropping" connection, but this > seems to be confusing). In the comment you said that this reconfig drops the connection. But it still does not, even in the updated definition above. You dropped this connection a few lines before this comment.