From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 47746CD338D; Thu, 6 Jun 2024 13:56:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 47746CD338D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1717671392; bh=HHgZR8j5yf/rizp0hFVFyhH+w5IE4UQW7xvvcYwlaQk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=GiBJ4Jvt7/ktMjd0VcysfC0jFQNnFEGxISsliI7XPvPUX4NXoUkigPTdcIFtGF6xf YnRK3faF6zWVZbRAk0kqUTv0MEKvQUw/NpfkvABfT49wn6/JwFsVLxvJEfMLVzj+cB 6fKaih48vRtCgzFLtHq1utoRAOI07VF5wiDQDNqY= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 51774CD338D for ; Thu, 6 Jun 2024 13:56:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 51774CD338D Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1sFAnG-000000064YH-2uvd; Thu, 06 Jun 2024 13:56:31 +0300 Content-Type: multipart/alternative; boundary="------------YVi9CLrYdN7Asu1HGptqU0nK" Message-ID: <657bb6f9-dfe3-418f-b46a-263978a7c84f@tarantool.org> Date: Thu, 6 Jun 2024 13:56:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <400b3ae2c1454663c6d975b55a68db2621132cc1.1713773432.git.skaplun@tarantool.org> In-Reply-To: <400b3ae2c1454663c6d975b55a68db2621132cc1.1713773432.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD95EAEBA1571A6350099262FE8AE219F4A131822ED8C31789F182A05F53808504032E93FF74D139ACF2EB5D77EF37489D1FDB69A75A79EA65B62BEE45D99412EB7992A494EFC6CB016 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77E216A0E97507353EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063753275FB77F6A31628638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A3DFA80F4C342C04A065755F5AF0EC9BD1D205BAFD213A32CC7F00164DA146DAFE8445B8C89999728AA50765F7900637DCE3DBD6F8E38AFD389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D2DCF9CF1F528DBCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CBFD98ABA943BD70B040F9FF01DFDA4A84AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C394C7EA7F95207A85BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6957A4DEDD2346B4275ECD9A6C639B01B78DA827A17800CE7D283DE70228D6EEC731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5C0429A933684C7DA5002B1117B3ED69634EA10C3B9E2CED60E58516B1639A14B823CB91A9FED034534781492E4B8EEAD21D4E6D365FE45D1BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF60509BD5E9137A9D73A0742FADBF1BEBDD749436EAB36F31B5937389C74C8D68ACCD0F0CDF7B389700094467C1BF539C2468A78FDF6F685D79A07563FB8699B9A40E0093023CA2335F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3qkQfioj9XQdeBklpEaiRw== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140BC8B29F4A1B4D1A4E870E1990E56C51CF78CAD815954100D0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v1 2/5] ci: add tablebump flavor for exotic builds X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------YVi9CLrYdN7Asu1HGptqU0nK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sergey, thanks for the patch! LGTM On 22.04.2024 11:49, Sergey Kaplun wrote: > This flavor enables the LUAJIT_ENABLE_TABLE_BUMP option to test table > bump optimization. > > Needed for tarantool/tarantool#9924 > --- > .github/workflows/exotic-builds-testing.yml | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml > index 859603bd..6ce100f4 100644 > --- a/.github/workflows/exotic-builds-testing.yml > +++ b/.github/workflows/exotic-builds-testing.yml > @@ -34,7 +34,7 @@ jobs: > BUILDTYPE: [Debug, Release] > ARCH: [ARM64, x86_64] > GC64: [ON, OFF] > - FLAVOR: [checkhook, dualnum, gdbjit, nojit, nounwind] > + FLAVOR: [checkhook, dualnum, gdbjit, nojit, nounwind, tablebump] > include: > - BUILDTYPE: Debug > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > @@ -50,12 +50,20 @@ jobs: > FLAVORFLAGS: -DLUAJIT_USE_GDBJIT=ON > - FLAVOR: nounwind > FLAVORFLAGS: -DLUAJIT_NO_UNWIND=ON > + - FLAVOR: tablebump > + FLAVORFLAGS: -DLUAJIT_ENABLE_TABLE_BUMP=ON > exclude: > - ARCH: ARM64 > GC64: OFF > # DUALNUM is default for ARM64, no need for additional testing. > - FLAVOR: dualnum > ARCH: ARM64 > + # Within table bump optimization enabled (and due to our modification > + # related to metrics), some offsets in GG_State stop fit in 12bit > + # immediate. Hence, the build failed due to the DASM error > + # (DASM_S_RANGE_I). > + - FLAVOR: tablebump > + ARCH: ARM64 > runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}'] > name: > > LuaJIT ${{ matrix.FLAVOR }} --------------YVi9CLrYdN7Asu1HGptqU0nK Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Sergey,

thanks for the patch! LGTM

On 22.04.2024 11:49, Sergey Kaplun wrote:
This flavor enables the LUAJIT_ENABLE_TABLE_BUMP option to test table
bump optimization.

Needed for tarantool/tarantool#9924
---
 .github/workflows/exotic-builds-testing.yml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
index 859603bd..6ce100f4 100644
--- a/.github/workflows/exotic-builds-testing.yml
+++ b/.github/workflows/exotic-builds-testing.yml
@@ -34,7 +34,7 @@ jobs:
         BUILDTYPE: [Debug, Release]
         ARCH: [ARM64, x86_64]
         GC64: [ON, OFF]
-        FLAVOR: [checkhook, dualnum, gdbjit, nojit, nounwind]
+        FLAVOR: [checkhook, dualnum, gdbjit, nojit, nounwind, tablebump]
         include:
           - BUILDTYPE: Debug
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
@@ -50,12 +50,20 @@ jobs:
             FLAVORFLAGS: -DLUAJIT_USE_GDBJIT=ON
           - FLAVOR: nounwind
             FLAVORFLAGS: -DLUAJIT_NO_UNWIND=ON
+          - FLAVOR: tablebump
+            FLAVORFLAGS: -DLUAJIT_ENABLE_TABLE_BUMP=ON
         exclude:
           - ARCH: ARM64
             GC64: OFF
           # DUALNUM is default for ARM64, no need for additional testing.
           - FLAVOR: dualnum
             ARCH: ARM64
+          # Within table bump optimization enabled (and due to our modification
+          # related to metrics), some offsets in GG_State stop fit in 12bit
+          # immediate. Hence, the build failed due to the DASM error
+          # (DASM_S_RANGE_I).
+          - FLAVOR: tablebump
+            ARCH: ARM64
     runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}']
     name: >
       LuaJIT ${{ matrix.FLAVOR }}
--------------YVi9CLrYdN7Asu1HGptqU0nK--