From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0CC9B2C852
	for <tarantool-patches@freelists.org>; Wed, 28 Nov 2018 07:37:04 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id URQXCPuPsKmp for <tarantool-patches@freelists.org>;
	Wed, 28 Nov 2018 07:37:03 -0500 (EST)
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3DF0D285C5
	for <tarantool-patches@freelists.org>; Wed, 28 Nov 2018 07:37:03 -0500 (EST)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: [tarantool-patches] Re: [PATCH 1/3] sql: EXPLAIN through net.box
 leads to SEGFAULT
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <1542920122.851013557@f398.i.mail.ru>
Date: Wed, 28 Nov 2018 15:36:51 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <6552029A-67C7-4466-95BA-B9D0FFA57C57@tarantool.org>
References: <cover.1542635129.git.v.shpilevoy@tarantool.org>
 <f5a6d3d2-b4bf-cbfb-e53c-b128ad497538@tarantool.org>
 <6104171d-f355-733c-d01b-016127ec389a@tarantool.org>
 <1542920122.851013557@f398.i.mail.ru>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

That=E2=80=99s why I don=E2=80=99t like any verbal agreements=E2=80=A6

My point is if result-set features column names,
then those columns must have type. I fail to come up with
example where resulting set features column names,
but columns don=E2=80=99t have types.
On the other hand, mb it is worth to send type ANY instead of
UNKNOWN, it makes sense to a greater or lesser extent.

> On 22 Nov 2018, at 23:55, =D0=9C=D0=B5=D1=80=D0=B3=D0=B5=D0=BD =
=D0=98=D0=BC=D0=B5=D0=B5=D0=B2 <imeevma@tarantool.org> wrote:
>=20
> After discussion we decided that this patch will serve us
> part of patch-set that should close newly filed bug:
> https://github.com/tarantool/tarantool/issues/3832
>=20
> The main Idea behind this ticket is that any statement
> should return column type for when it returns column name.
> And this ticket allow us to find an error without falling
> into SEGMENTATION FAULT or returning less metadata.
>=20
> =D0=A7=D0=B5=D1=82=D0=B2=D0=B5=D1=80=D0=B3, 22 =D0=BD=D0=BE=D1=8F=D0=B1=D1=
=80=D1=8F 2018, 21:31 +03:00 =D0=BE=D1=82 Vladislav Shpilevoy =
<v.shpilevoy@tarantool.org>:
>=20
> It was just a question, "why did you decide to do not
> send type". It was not necessary to start sending UNKNOWN. I
> think, that unknown type should be sent never.