From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6EA9F6EC55; Sat, 10 Jul 2021 17:36:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6EA9F6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625927793; bh=Ivai9VcJQxCBpQ54Xw9x39cOPy+/9vtvm/Cm8YPKRS0=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=paJ7M1IGpVO+rCCoaPCIJcoJ8Y3JJU7B1DjLOM1wUUcC/3RzEsXJ0ZdaYot5z7TRM bvKfmDxQtOnGRUMS/NMeS4BhO/sImSNBXijCZL3GAsgZW/zI/9tzGwLll/1DLmAhdT d5K8/3LMqyvrhFiFTl+zL6NJW9V5QAVdgGKVAHyU= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 30F6A6EC55 for ; Sat, 10 Jul 2021 17:36:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 30F6A6EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m2E5n-0004D9-Lv; Sat, 10 Jul 2021 17:36:31 +0300 To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <64e8f1df-a3e9-fb7d-1c92-6b2b28ac8205@tarantool.org> Date: Sat, 10 Jul 2021 17:36:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB0C620705B15DE32D6B8174B3EFF2BD9A182A05F538085040DCFD8E019D3471801E113C70D08D83F29DAC581C4FDB3FCDA9246D9DC8F20601 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76DA79C5AFF329FDBEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B05885A782BE20C5EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F251512A6E9D53F638481CE3AB477696D7CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B953A8A48A05D51F175ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A509FA733BF6BE75FA0373F9541B2F03D798D994A04043147ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753753CEE10E4ED4A7410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34697E0FA301E282150D0CCEE47544813ADF5815BF3B143A9851813073C94252A48C4E4CDBE8E219CA1D7E09C32AA3244CD8403181410C56F8E65A75DD8E648A6660759606DA2E136A729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojwCsty+r9xmAFqAbjrJAYZg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D17AD9026B3F72B4A0D6C85C8C97B81C583D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 2/3] sql: fix uuid behaviour in least() and greatest() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! I abandoned this patch because I realized that a more global solution was needed. On 08.07.2021 00:42, Vladislav Shpilevoy wrote: > Thanks for the patch! > >> diff --git a/test/sql-tap/gh-6164-uuid-follow-ups.test.lua b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua >> index d8fa700ea..8872f9f23 100755 >> --- a/test/sql-tap/gh-6164-uuid-follow-ups.test.lua >> +++ b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua >> @@ -13,4 +15,21 @@ test:do_execsql_test( >> '11111111-1111-1111-1111-111111111111' >> }) >> >> +-- Make sure that functions greatest() and least() can properly work with uuid. >> +test:do_execsql_test( >> + "gh-6164-2", >> + [[ >> + SELECT GREATEST(true, 1, x'33', cast('11111111-1111-1111-1111-111111111111' as uuid), 1e10); > Please, try to remain inside 80 symbols line width limit. The same below. > >> + ]], { >> + uuid >> + }) >> + >> +test:do_execsql_test( >> + "gh-6164-3", >> + [[ >> + SELECT LEAST(true, 1, x'33', cast('11111111-1111-1111-1111-111111111111' as uuid), 1e10); >> + ]], { >> + true >> + }) >> + >> test:finish_test() >>