From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 97B7A445320
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 28 Jul 2020 11:34:50 +0300 (MSK)
References: <20200716182032.84609-1-olegrok@tarantool.org>
 <ec8d3d05-b21b-39cb-1e02-f7dbbc49842a@tarantool.org>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <64d25074-c400-b551-064f-01046d3d8edf@tarantool.org>
Date: Tue, 28 Jul 2020 11:34:48 +0300
MIME-Version: 1.0
In-Reply-To: <ec8d3d05-b21b-39cb-1e02-f7dbbc49842a@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH] lua: introduce function to check
 that passed value is uuid
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid Vasiliev <lvasiliev@tarantool.org>, v.shpilevoy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for review.

On 28/07/2020 11:23, Leonid Vasiliev wrote:
> Hi! Thank you for the patch.
> LGTM.
>
> Up to you:
>
>> We've already have is_decimal function that checks allowed value
>
> If I'm not mistaken: "We already have".

Yes, thanks. Fixed and force-pushed.


And seems patch has two LGTMs and could be merged.

CCed Kirill.