From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 684412BA2B for ; Wed, 4 Apr 2018 06:26:10 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KeP81g-v07rd for ; Wed, 4 Apr 2018 06:26:10 -0400 (EDT) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2B0DA2B983 for ; Wed, 4 Apr 2018 06:26:09 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 2/4] sql: remove unused error codes, use enum instead of defines References: <3FC50B7F-FE28-4F8C-A79C-C287FD6EA1CB@tarantool.org> From: Vladislav Shpilevoy Message-ID: <64bd8cfd-48ec-1171-d58e-94779d17b3f9@tarantool.org> Date: Wed, 4 Apr 2018 13:26:07 +0300 MIME-Version: 1.0 In-Reply-To: <3FC50B7F-FE28-4F8C-A79C-C287FD6EA1CB@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, "n.pettik" > I do like move to enum, but what about removing this obsolete ’SQLITE’ prefix? > Let it be just ’SQL_’. Moreover, some error seems to be SQLite specific. > Great time to remove them, isn’t it? > If you don’t want or don’t have time for this boring routine, you can create issue > with ‘good first issue’ label. I am afraid that a diff will be huge, if a rename SQLITE_OK, for example. Lets do it later, when more source code and error codes will be removed. https://github.com/tarantool/tarantool/issues/3315 Please, review the huge diff below very carefully. I could make a mistake here. diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h index f8f4e566b..6ea8c91d7 100644 --- a/src/box/sql/vdbeInt.h +++ b/src/box/sql/vdbeInt.h @@ -442,7 +442,6 @@ struct Vdbe {      int nScan;        /* Entries in aScan[] */      ScanStatus *aScan;    /* Scan definitions for sqlite3_stmt_scanstatus() */  #endif -  };  /*