From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AFAA443D678 for ; Wed, 23 Oct 2019 00:22:59 +0300 (MSK) References: <20191015155007.6834-1-i.kosarev@tarantool.org> From: Vladislav Shpilevoy Message-ID: <649183f1-0852-734d-fe75-5d6ed1e956eb@tarantool.org> Date: Tue, 22 Oct 2019 23:28:15 +0200 MIME-Version: 1.0 In-Reply-To: <20191015155007.6834-1-i.kosarev@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH] replication: cancel replica joining thread at exit List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@freelists.org, Ilya Kosarev , tarantool-patches@dev.tarantool.org Hi! Thanks for the patch! > diff --git a/src/box/memtx_engine.h b/src/box/memtx_engine.h > index c092f5d8e..43e16879d 100644 > --- a/src/box/memtx_engine.h > +++ b/src/box/memtx_engine.h > @@ -107,6 +107,8 @@ struct memtx_engine { > uint64_t snap_io_rate_limit; > /** Skip invalid snapshot records if this flag is set. */ > bool force_recovery; > + /** cord being currently used to join replica **/ Please, start the sentence from a capital letter, and finish with a dot. Also, as you probably have seen we use */ commend end mark, never **/. I would also mention, that we need that pointer only to be able to cancel the cord. Nothing else. > + struct cord *replica_join_cord; > /** Common quota for tuples and indexes. */ > struct quota quota; > /** >