From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A070420017 for ; Wed, 1 Aug 2018 18:14:53 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tx3iT6HsKbVU for ; Wed, 1 Aug 2018 18:14:53 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 33D9B2042E for ; Wed, 1 Aug 2018 18:14:52 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v3 1/1] sql: tarantoolctl "enter" with set language From: Vladislav Shpilevoy References: Message-ID: <6484efa6-f68b-fc43-6d6c-0ff42e7a01a0@tarantool.org> Date: Thu, 2 Aug 2018 01:14:50 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, imeevma@tarantool.org Cc: Kirill Yukhin Kirill. How about to push it? On 30/07/2018 13:39, Vladislav Shpilevoy wrote: > Thanks for the patch! > > Please, write me in 'Copy' when sending a patch on review. > > The patch LGTM. > > On 30/07/2018 11:33, imeevma@tarantool.org wrote: >> This patch allow to use option "--language" with >> "tarantoolctl enter" command. Also default value >> for language were added in default configuration >> file. Language is either SQL or Lua. >> >> Closes #2385. >> >> @TarantoolBot document >> Title: Language selection for tarantoolctl >> "enter". >> User can select either Lua or SQL when he uses tarantoolctl >>   "enter" command. It can be done using "--language=" >> syntax. Default language is set in tarantoolctl config file. >> Usage: >> tarantoolctl enter --language=SQL >> tarantoolctl enter --language=Lua >> --- >> Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-2385-select-input-language-tarantoolctl >> Issue: https://github.com/tarantool/tarantool/issues/2385 >> >