From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 126F015DEA85; Mon, 17 Nov 2025 16:26:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 126F015DEA85 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763385971; bh=OFmq+aEDsfXIviMKnBYbFXc7mVhNdehTSVcNAn2/F2s=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=OzQ0/QhvRlgIBSez6Wzbfsi4yLKa1ynb01rNCXUsZEtRQPfHCzWfZ6ZqcQQSaPHJS tdnkj/dgDYUods/RDbBfvptN/MS+aZ1OdC8TXLgF6O2jlvJ7AufoNf4L++LcDNEjnI +wlNBKhTmoIirIeK8i40aJDCwBMTBtappCxLki6o= Received: from send80.i.mail.ru (send80.i.mail.ru [89.221.237.175]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3DDFB15B7878 for ; Mon, 17 Nov 2025 16:25:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3DDFB15B7878 Received: by exim-smtp-77df68b9cf-k4thg with esmtpa (envelope-from ) id 1vKzEm-00000000Aek-1NiO; Mon, 17 Nov 2025 16:25:44 +0300 Content-Type: multipart/alternative; boundary="------------G3mqApg0fLZU0q7QppcGJopP" Message-ID: <6464e521-99ca-436a-8662-919386d411b0@tarantool.org> Date: Mon, 17 Nov 2025 16:25:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <8f29317ee2bd8403e728fb44331293e28693bbfa.1761301736.git.skaplun@tarantool.org> In-Reply-To: <8f29317ee2bd8403e728fb44331293e28693bbfa.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9110BAFCBE6BD1D167AB5004BEA225D964407BC14E2B63626182A05F53808504018140950164154173DE06ABAFEAF6705A017ACA6A59BB25D3C1CBB97E487F8EE067A636123F0E402 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7956F10FFCC7409BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566D0BE23D09F2BEA509CC3C8DA8C4D9EB8408A415DC94CB97D7726E77B3E449B81389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22490F250D17497FEF6176E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B8DBB596EC94336063AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7356436AE5DD6441DC7C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A561F70D076BF2C3DC5002B1117B3ED6966E74E8BAEB2F590FE20DC3F561CE4150823CB91A9FED034534781492E4B8EEAD14747542773C033FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF3A301B465B55FD4B3762D685062BAA99B1ED958562D0790FB94EE730AB89DBEAD917AD9EEFBA970EDD12B02666E49356CA44F427FE02FE07E17169D636A22569A019442DC181A4A4111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW1WSlMI2SP9nc= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59B00194A616061D853DE06ABAFEAF6705A017ACA6A59BB25DB7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 23/41] perf: adjust ray in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------G3mqApg0fLZU0q7QppcGJopP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! See my comments. Sergey On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > The output is redirected to /dev/null. The check is skipped since it is > very inconvenient to check the binary output, especially since it may be > configured by the parameter. > --- > perf/LuaJIT-benches/ray.lua | 76 ++++++++++++++++++++++++------------- > 1 file changed, 50 insertions(+), 26 deletions(-) > > diff --git a/perf/LuaJIT-benches/ray.lua b/perf/LuaJIT-benches/ray.lua > index 2acc24c0..f7b76d0a 100644 > --- a/perf/LuaJIT-benches/ray.lua > +++ b/perf/LuaJIT-benches/ray.lua > @@ -1,10 +1,8 @@ > +local bench = require("bench").new(arg) > + > local sqrt = math.sqrt > local huge = math.huge > - > -local delta = 1 > -while delta * delta + 1 ~= 1 do > - delta = delta * 0.5 > -end > +local delta > > local function length(x, y, z) return sqrt(x*x + y*y + z*z) end > local function vlen(v) return length(v[1], v[2], v[3]) end > @@ -110,26 +108,52 @@ end > > > local level, n, ss = tonumber(arg[1]) or 9, tonumber(arg[2]) or 256, 4 > -local iss = 1/ss > -local gf = 255/(ss*ss) > - > -io.write(("P5\n%d %d\n255\n"):format(n, n)) > -local light = { unitise(-1, -3, 2) } > -ilight = { -light[1], -light[2], -light[3] } > -local camera = { 0, 0, -4 } > -local dir = { 0, 0, 0 } > - > -local scene = create(level, {0, -1, 0}, 1) > - > -for y = n/2-1, -n/2, -1 do > - for x = -n/2, n/2-1 do > - local g = 0 > - for d = y, y+.99, iss do > - for e = x, x+.99, iss do > - dir[1], dir[2], dir[3] = unitise(e, d, n) > - g = g + ray_trace(light, camera, dir, scene) > + > +local stdout = io.output() > + > +bench:add({ > + name = "ray", > + -- Avoid skip checking here, since it is not very convenient. > + -- If you want to check the behaviour -- drop the setup > + -- function. > + skip_check = true, > + setup = function() > + io.output("/dev/null") > + end, > + payload = function() > + local iss = 1/ss please add more whitespaces, here and below > + local gf = 255/(ss*ss) > + > + delta = 1 > + while delta * delta + 1 ~= 1 do > + delta = delta * 0.5 > + end > + > + io.write(("P5\n%d %d\n255\n"):format(n, n)) > + local light = { unitise(-1, -3, 2) } > + ilight = { -light[1], -light[2], -light[3] } > + local camera = { 0, 0, -4 } > + local dir = { 0, 0, 0 } > + > + local scene = create(level, {0, -1, 0}, 1) > + > + for y = n/2-1, -n/2, -1 do > + for x = -n/2, n/2-1 do > + local g = 0 > + for d = y, y+.99, iss do > + for e = x, x+.99, iss do > + dir[1], dir[2], dir[3] = unitise(e, d, n) > + g = g + ray_trace(light, camera, dir, scene) > + end > + end > + io.write(string.char(math.floor(0.5 + g*gf))) > end > end > - io.write(string.char(math.floor(0.5 + g*gf))) > - end > -end > + end, > + teardown = function() > + io.output(stdout) > + end, > + items = n * n * level, > +}) > + > +bench:run_and_report() --------------G3mqApg0fLZU0q7QppcGJopP Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! See my comments.

Sergey

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

The output is redirected to /dev/null. The check is skipped since it is
very inconvenient to check the binary output, especially since it may be
configured by the parameter.
---
 perf/LuaJIT-benches/ray.lua | 76 ++++++++++++++++++++++++-------------
 1 file changed, 50 insertions(+), 26 deletions(-)

diff --git a/perf/LuaJIT-benches/ray.lua b/perf/LuaJIT-benches/ray.lua
index 2acc24c0..f7b76d0a 100644
--- a/perf/LuaJIT-benches/ray.lua
+++ b/perf/LuaJIT-benches/ray.lua
@@ -1,10 +1,8 @@
+local bench = require("bench").new(arg)
+
 local sqrt = math.sqrt
 local huge = math.huge
-
-local delta = 1
-while delta * delta + 1 ~= 1 do
-  delta = delta * 0.5
-end
+local delta
 
 local function length(x, y, z)  return sqrt(x*x + y*y + z*z) end
 local function vlen(v)          return length(v[1], v[2], v[3]) end
@@ -110,26 +108,52 @@ end
 
 
 local level, n, ss = tonumber(arg[1]) or 9, tonumber(arg[2]) or 256, 4
-local iss = 1/ss
-local gf = 255/(ss*ss)
-
-io.write(("P5\n%d %d\n255\n"):format(n, n))
-local light = { unitise(-1, -3, 2) }
-ilight = { -light[1], -light[2], -light[3] }
-local camera = { 0, 0, -4 }
-local dir = { 0, 0, 0 }
-
-local scene = create(level, {0, -1, 0}, 1)
-
-for y = n/2-1, -n/2, -1 do
-  for x = -n/2, n/2-1 do
-    local g = 0
-    for d = y, y+.99, iss do
-      for e = x, x+.99, iss do
-        dir[1], dir[2], dir[3] = unitise(e, d, n)
-        g = g + ray_trace(light, camera, dir, scene) 
+
+local stdout = io.output()
+
+bench:add({
+  name = "ray",
+  -- Avoid skip checking here, since it is not very convenient.
+  -- If you want to check the behaviour -- drop the setup
+  -- function.
+  skip_check = true,
+  setup = function()
+    io.output("/dev/null")
+  end,
+  payload = function()
+    local iss = 1/ss
please add more whitespaces, here and below 
+    local gf = 255/(ss*ss)
+
+    delta = 1
+    while delta * delta + 1 ~= 1 do
+      delta = delta * 0.5
+    end
+
+    io.write(("P5\n%d %d\n255\n"):format(n, n))
+    local light = { unitise(-1, -3, 2) }
+    ilight = { -light[1], -light[2], -light[3] }
+    local camera = { 0, 0, -4 }
+    local dir = { 0, 0, 0 }
+
+    local scene = create(level, {0, -1, 0}, 1)
+
+    for y = n/2-1, -n/2, -1 do
+      for x = -n/2, n/2-1 do
+        local g = 0
+        for d = y, y+.99, iss do
+          for e = x, x+.99, iss do
+            dir[1], dir[2], dir[3] = unitise(e, d, n)
+            g = g + ray_trace(light, camera, dir, scene)
+          end
+        end
+        io.write(string.char(math.floor(0.5 + g*gf)))
       end
     end
-    io.write(string.char(math.floor(0.5 + g*gf)))
-  end
-end
+  end,
+  teardown = function()
+    io.output(stdout)
+  end,
+  items = n * n * level,
+})
+
+bench:run_and_report()
--------------G3mqApg0fLZU0q7QppcGJopP--