From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E48ED9D9B74; Wed, 7 Feb 2024 10:01:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E48ED9D9B74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707289296; bh=duqFtc8a9JO6Xdh7AyI9JZJ12AxLZeqaJwQxsZt5Bo4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UrmSUYb+9ATciwsU492mWFTgQeYAy1Oc6qta1FVzlyTN0AJDlwMAal9ZfbtGru2De GGys2hLWdEtTasXzNt2M4kB0Z48FbNPb8TdweCavVreDUAuQhZMnIQlNSeGdWsBPdM 8TOPTcOJVbLTSHGTeDhvgqZCrh2L5ciiqKe7yKNA= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1334456CD16 for ; Wed, 7 Feb 2024 10:01:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1334456CD16 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1rXbw5-0000000BkaN-1ldq; Wed, 07 Feb 2024 10:01:33 +0300 Message-ID: <6445f4f0-7960-4c9a-9cd0-c17014bf6108@tarantool.org> Date: Wed, 7 Feb 2024 10:01:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD94C460F083DF69F51F716FD8A96C6C408CD848DA42FE26380182A05F5380850402DDD24102869F11333594132A326AF8B47DA6F405C29B00A5D75C012EE7CF6312031A3DD069C1E5A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE729E6537B8C47FA6DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063738C1CCEC8FAC1CB98638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D2D3878C2B23A9B8C2C24975D43837008E82130AEC6D46D5CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EDCF5861DED71B2F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063789AE0CFEAB31AB47D32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C0B2D370F7B14D4BC4B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE33AC447995A7AD187441229DB5CFFAA63A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73533F64B4C514AF25EC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5CDD98627143907EB5002B1117B3ED69621EF0E5C20D2905B47A99E6294EE8661823CB91A9FED034534781492E4B8EEADBD39A56654533F91BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF91EFAAD6007256AF2797A1A01770F1C3E36FBFB0607836DA96EE9CE61AB9C3F3B268D298D11CBB1A807D692F32DC7032D1CB8E672B9E7B58D2AF9BDB4F5A4A9A7174B1AC5BE05DE65F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnNiISkhlGWvcg== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458F11AEB62E3FC6E1EAC4385294E02B5FB782B90FF7DBA55A52A00D8B779C48D67645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 16/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey thanks for the fix! LGTM On 2/6/24 16:48, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comment below. > > On 05.02.24, Sergey Bronnikov wrote: >> Hi, Sergey >> >> thanks for the patch! LGTM with a minor comment >> >> On 1/29/24 13:45, Sergey Kaplun wrote: > > >>> @@ -14,7 +14,7 @@ local function ptreq(a, b) >>> return ffi.cast("void *", a) == ffi.cast("void *", b) >>> end >>> >>> -do >>> +do --- metatype index newindex >> isn't better: "metatype with index and newindex metamethods" or smthing >> like this? >> >> This descriptions are for humans mostly and would be better to convert >> these keywords to readable sentence. >> >> same for test names below > Fixed. See the iterative patch below: > > =================================================================== > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_metatype.lua b/test/LuaJIT-tests/lib/ffi/ffi_metatype.lua > index b0054b1a..3fea5341 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_metatype.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_metatype.lua > @@ -14,7 +14,7 @@ local function ptreq(a, b) > return ffi.cast("void *", a) == ffi.cast("void *", b) > end > > -do --- metatype index newindex > +do --- metatype with index and newindex metamethods > local nidx = {} > local tp = ffi.metatype("idx1_t", { > __index = { foo = 99, method = function(c, v) return v end }, > @@ -45,7 +45,7 @@ do --- metatype index newindex > fails(function(cp) cp.bar = 42 end, cp) > end > > -do --- metatype index newindex with upvalues > +do --- index and newindex metamethods use upvalues > local uc, uk, uv > local tp = ffi.metatype("idx2_t", { > __index = function(c, k, x, y) > @@ -78,7 +78,7 @@ do --- metatype index newindex with upvalues > fails(function(p) p[0] = 11 end, p) > end > > -do --- metatype index newindex with upvalues via setmetatable > +do --- index and newindex metamethods as metaobjects use upvalues > local uc, uk, uv > local ti, tn = {}, {} > local tp = ffi.metatype("idx3_t", { > =================================================================== > > > >>> jit_complex.lua