From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1FA8842EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 19 Jun 2020 02:02:56 +0300 (MSK)
References: <cover.1591345474.git.runsfor@gmail.com>
 <ef0528997c2d120730f40af9f6d70c7bd2db08c1.1591345474.git.runsfor@gmail.com>
 <67c75c01-8503-2355-e1f7-9644def2179c@tarantool.org>
 <EE69E031-21CF-49AC-89CE-8E57CB006E84@gmail.com>
 <6b8b0f63-0a3f-d3ae-7596-2611ea433d44@tarantool.org>
 <6D02837E-BBEB-4CB9-806F-D5D8E66014B1@gmail.com>
 <e1376d40-2d36-119d-d237-d53e64b28d23@tarantool.org>
 <8DEA1673-33E4-4930-9C61-45DEC371FE73@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <642b3dbc-98f1-e09a-a71c-f94b8a6091cc@tarantool.org>
Date: Fri, 19 Jun 2020 01:02:55 +0200
MIME-Version: 1.0
In-Reply-To: <8DEA1673-33E4-4930-9C61-45DEC371FE73@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/2] feedback: collect db engines
	and index features
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: =?UTF-8?B?0JjQu9GM0Y8g0JrQvtC90Y7RhdC+0LI=?= <runsfor@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the fixes!

The patch LGTM except that its test is failing here:
https://travis-ci.org/github/tarantool/tarantool/jobs/699753951

Also it fails locally on my machine.

======================================================================================
WORKR TEST                                            PARAMS          RESULT
---------------------------------------------------------------------------------
[001] box-tap/feedback_daemon.test.lua                                
[001] not ok 15 - failed subtests #  
[001] Traceback:
[001] [Lua ] function 'test' at <builtin/tap.lua:249>
[001] [main] at </Users/gerold/Work/Repositories/tarantool/test/box-tap/feedback_daemon.test.lua:0>
[001] 
[001] {'failed': 2, 'planned': 10}
[001] 
[001] not ok 22 - data is equal #  
[001] Expected: {"arch":"x64","features":{"schema":{"local_spaces":1,"functional_indices":0,"hash_indices":1,"rtree_indices":0,"temporary_spaces":1,"tree_indices":1,"jsonpath_indices":0,"vinyl_spaces":0,"bitset_indices":1,"memtx_spaces":1}},"server_id":"fb2c934e-e20e-44c3-824d-2ee854863569","is_docker":false,"os":"OSX","feedback_type":"version","cluster_id":"26f54eba-e463-4248-82ed-03b1e504ec82","tarantool_version":"2.5.0-148-g15a09c910","feedback_version":1}
[001] Got:      {"arch":"x64","features":{"schema":{"local_spaces":0,"functional_indices":0,"hash_indices":0,"rtree_indices":0,"temporary_spaces":0,"tree_indices":0,"jsonpath_indices":0,"vinyl_spaces":0,"bitset_indices":0,"memtx_spaces":0}},"server_id":"fb2c934e-e20e-44c3-824d-2ee854863569","is_docker":false,"os":"OSX","feedback_type":"version","cluster_id":"26f54eba-e463-4248-82ed-03b1e504ec82","tarantool_version":"2.5.0-148-g15a09c910","feedback_version":1}
[001] Traceback:
[001] [main] at </Users/gerold/Work/Repositories/tarantool/test/box-tap/feedback_daemon.test.lua:0>
[001] 
[001] Rejected result file: box-tap/feedback_daemon.reject
[001] [ fail ]
[Main process] Got failed test; gently terminate all workers...
[001] Worker "001_box-tap" got failed test; stopping the server...
---------------------------------------------------------------------------------