From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 86E8746970E
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 23 Dec 2019 22:16:05 +0300 (MSK)
References: <cover.1576944064.git.imeevma@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <63a11f3f-f8aa-166e-feab-85746e8b08a0@tarantool.org>
Date: Mon, 23 Dec 2019 20:16:02 +0100
MIME-Version: 1.0
In-Reply-To: <cover.1576944064.git.imeevma@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v1 0/2] Add DOUBLE type to SQL
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Thanks for the patch! LGTM.

Nikita, please, do a second review.

On 21/12/2019 17:03, imeevma@tarantool.org wrote:
> This patch-set adds the DOUBLE type to SQL. In the first patch of
> the set, the field type DOUBLE is added to Tarantool. In the
> second patch, the DOUBLE type is added to SQL.
> 
> https://github.com/tarantool/tarantool/issues/3812
> https://github.com/tarantool/tarantool/tree/imeevma/gh-3812-add-double-type
> 
> Mergen Imeev (2):
>   box: introduce DOUBLE field type
>   sql: introduce DOUBLE type
> 
>  extra/mkkeywordhash.c                      |   2 +-
>  src/box/field_def.c                        |  28 ++-
>  src/box/field_def.h                        |   1 +
>  src/box/sql/expr.c                         |   6 +-
>  src/box/sql/parse.y                        |   3 +-
>  src/box/sql/sqlInt.h                       |   3 +-
>  src/box/sql/vdbe.c                         |   4 +
>  src/box/sql/vdbemem.c                      |  15 +-
>  src/box/tuple_compare.cc                   |  24 ++
>  test/engine/insert.result                  | 151 +++++++++++
>  test/engine/insert.test.lua                |  51 ++++
>  test/sql/gh-3888-values-blob-assert.result |   4 +-
>  test/sql/misc.result                       |   4 +-
>  test/sql/types.result                      | 390 ++++++++++++++++++++++++++++-
>  test/sql/types.test.lua                    |  66 +++++
>  15 files changed, 716 insertions(+), 36 deletions(-)
>