From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5607F42EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 23 Jun 2020 11:39:28 +0300 (MSK)
References: <cover.1592589312.git.sergepetrenko@tarantool.org>
 <46ed0cc08e6ecf7ee7c9250d9cdfc3d68aa5c764.1592589312.git.sergepetrenko@tarantool.org>
 <30f75001-3ecc-9d7f-9cba-88c824087f4e@tarantool.org>
 <ecb9c03f-0977-7395-c7c5-8780e95ec7db@tarantool.org>
 <bc71772b-76b7-88c1-0096-9b96d08483ea@tarantool.org>
 <c56a7c97-dd93-adff-5fbd-37b0d05ed7aa@tarantool.org>
 <aee710ff-535e-d5f3-6395-2c039a5be89e@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <6349f4ba-88c2-e6b4-1785-50e18dd5d010@tarantool.org>
Date: Tue, 23 Jun 2020 11:39:26 +0300
MIME-Version: 1.0
In-Reply-To: <aee710ff-535e-d5f3-6395-2c039a5be89e@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 1/2] box: rework local_recovery to
 use async txn_commit
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, sergos@tarantool.org, gorcunov@tarantool.org, lvasiliev@tarantool.org
Cc: tarantool-patches@dev.tarantool.org


23.06.2020 00:43, Vladislav Shpilevoy пишет:
> I am looking at the commit which added on_write_failure.
> Why can't we reuse on_rollback trigger? As we discussed,
> we can pass whatever we want using txn->signature. So
> for manual rollback we can set it to -1, for write failure
> to -2, for limbo rollback to -3, for timeout to -4, etc.
>
> I am just afraid that +16 bytes for transaction object
> may affect performance of the async transactions.

We can. I've just done it & dropped the additionnal commit

(the one that hacked the trigger removal in recovery.

-- 
Serge Petrenko