From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 614DF4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sun,  5 Apr 2020 22:32:54 +0300 (MSK)
References: <cover.1585312984.git.imun@tarantool.org>
 <58bc0a41c265e891099d20f4362f3baa887d3bdf.1585312984.git.imun@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <630f27a6-f0ac-5900-a3d6-11eb44326ee9@tarantool.org>
Date: Sun, 5 Apr 2020 21:32:52 +0200
MIME-Version: 1.0
In-Reply-To: <58bc0a41c265e891099d20f4362f3baa887d3bdf.1585312984.git.imun@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/4] test: adjust luajit-tap testing
 machinery
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>, Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

On 27/03/2020 14:23, Igor Munkin wrote:
> This changeset makes possible to run luajit-tap tests requiring
> libraries implemented in C:
> * symlink to luajit test is created on configuration phase instead of
>   build one.

What is the difference? Is it really necessary for anything? To be
able to see CMake files in there?

> * introduced a CMake function for building shared libraries required for
>   luajit tests.
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>  test/CMakeLists.txt | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
> index 9b5df7dc5..00fce7270 100644
> --- a/test/CMakeLists.txt
> +++ b/test/CMakeLists.txt
> @@ -13,6 +13,13 @@ function(build_module module files)
>      endif(TARGET_OS_DARWIN)
>  endfunction()
>  
> +function(build_lualib lib sources)

This function is introduced in tarantool, but required
for luajit. On the contrary, luajit is required for tarantool.
This is cyclic dependency, which makes impossible to run such
tests inside luajit. I think luajit tests should be kept self
sufficient. Otherwise it makes no sense to keep them in luajit
repository. If you anyway can't run them in there, and need to
create some test-wrappers from tarantool's side.

Alternative is to move them completely to tarantool. But current
way is not right. It is half of one and half of other solution.

> +    add_library(${lib} SHARED ${sources})
> +    set_target_properties(${lib} PROPERTIES PREFIX "")
> +    if(TARGET_OS_DARWIN)
> +        set_target_properties(${lib} PROPERTIES LINK_FLAGS "-undefined dynamic_lookup")
> +    endif(TARGET_OS_DARWIN)
> +endfunction()