From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D686A6F3C7; Fri, 26 Mar 2021 18:41:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D686A6F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616773305; bh=ipkpqrp/ooQ/n1/CktLnkFPjbvKGm6df/Byk2JNiDoU=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=H5bAQ9Kom9SbBSAIClSMF4VMD2p96hkDHSd796i2f3FInCb/0L5iYRHPtiToZmkrz F9alFpWsHQXtRWAd1/TsfCFhRUz84y1qmfpg4GzL3M23VJlFjqYdLr/friROHBX8b1 71zwCxCchLfsRBDzltUm2j7nhMoRMMGb3KArhmRc= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A24F56F3C7 for ; Fri, 26 Mar 2021 18:41:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A24F56F3C7 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1lPoak-0008P8-U4; Fri, 26 Mar 2021 18:41:43 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) In-Reply-To: <9bf043d0714a15e51ca6e6f0778722da04e4c934.1616743343.git.skaplun@tarantool.org> Date: Fri, 26 Mar 2021 18:41:42 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <628C071F-3248-4559-9FC6-724E1EEEF7E8@tarantool.org> References: <9bf043d0714a15e51ca6e6f0778722da04e4c934.1616743343.git.skaplun@tarantool.org> To: Sergey Kaplun X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294DD38BE31D7797EF84C856624A09E4809182A05F5380850400E9B43E5B42CB62CBA8A19636DB79626C6DFA97EAD87BFEE86C70A1D1CC11138 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE760302A529BCAAAFCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B2BC59D094D41B978638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5DFAA029205FD20529BADD9417AB851C59A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE709B92020B71E24959FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34C82C86BFC697D19117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF40B429B92CE9FF2BBA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6BD8D6CC6D5691A2276E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249B372FE9A2E580EFC725E5C173C3A84C3A1C30C8AFC676C8B35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831AF3C373D38A6C61B6805EF8F972D3E44 X-C1DE0DAB: 0D63561A33F958A5120372A92D9141C26E950E46C9C6910432C609EE34C47333D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340D3A19269BBEBAAF1B5B4A903066C21AC989BDD0FCF63068E1D9891FABD42036DF15BBD6B4BD99AC1D7E09C32AA3244C4D4A56764016247CA9EDC5C3D26490AC7101BF96129E4011FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAjbLIBJyB1KbQ== X-Mailru-Sender: 455D65AE3A139168626D8C76E86D3AC03FBD336013567441B6A482FA07DE695FDDAC019A3742A8B676D79013C85012CDC77752E0C033A69E4BBE7EBD99111A499D0AB74157175C036C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 21/30] test: disable test for getfenv in closure tailcall X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" LGTM. Sergos > On 26 Mar 2021, at 10:43, Sergey Kaplun wrote: >=20 > LuaJIT doesn't take into account tail calls for call-level counting, = so > getfenv() behaviour is different from Lua 5.1 in tail calls. >=20 > This patch disables test for the return result of tail call getfenv(). > Default value (equals 1) of getfenv() function's argument (function > level) is invalid for this tail call -- LuaJIT can't provide necessary > debug information for the frame. >=20 > Relates to tarantool/tarantool#5713 > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/closure.lua | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/test/PUC-Lua-5.1-tests/closure.lua = b/test/PUC-Lua-5.1-tests/closure.lua > index 7f56ab8..7af842f 100644 > --- a/test/PUC-Lua-5.1-tests/closure.lua > +++ b/test/PUC-Lua-5.1-tests/closure.lua > @@ -174,7 +174,14 @@ f =3D coroutine.wrap(foo) > local a =3D {} > assert(f(a) =3D=3D _G) > local a,b =3D pcall(f) > -assert(a and b =3D=3D _G) > +-- LuaJIT doesn't take into account tail calls for call-level > +-- counting, so getfenv() behaviour is different in tail calls. > +-- For example, this `pcall()` returns false, because getfenv() > +-- default level is 1 which is invalid for this case when > +-- is called from tail call (lj_debug_frame() returns NULL). > +-- See also https://github.com/tarantool/tarantool/issues/5713. > +-- FIXME: Test is disabled for LuaJIT for now. > +-- assert(a and b =3D=3D _G) >=20 >=20 > -- tests for multiple yield/resume arguments > --=20 > 2.31.0 >=20