From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C1C4C445320
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 12 Jul 2020 20:16:41 +0300 (MSK)
References: <1594221263-6228-1-git-send-email-alyapunov@tarantool.org>
 <1594221263-6228-13-git-send-email-alyapunov@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <62507acd-6cce-e965-5294-21ea8b17ffd5@tarantool.org>
Date: Sun, 12 Jul 2020 19:16:39 +0200
MIME-Version: 1.0
In-Reply-To: <1594221263-6228-13-git-send-email-alyapunov@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 12/16] introduce tuple smart pointers
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Aleksandr Lyapunov <alyapunov@tarantool.org>, tarantool-patches@dev.tarantool.org

This looks like an overkill. You literally use these
'smart pointers' 2 times. Two of these functions, each
used 1 time. Why do you need all of that? Is it too hard
to add explicit tuple_ref/unref in these 2 places?