From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0767242EF5C for ; Thu, 11 Jun 2020 22:56:32 +0300 (MSK) References: <20200421213930.28713-1-gorcunov@gmail.com> <20200610075257.GO134822@grain> <20200611194316.GP134822@grain> From: Vladislav Shpilevoy Message-ID: <616766fd-204e-805e-bb19-2ed2e06e73ec@tarantool.org> Date: Thu, 11 Jun 2020 21:56:31 +0200 MIME-Version: 1.0 In-Reply-To: <20200611194316.GP134822@grain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH] fio/coio: handle partial writes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov Cc: tml On 11/06/2020 21:43, Cyrill Gorcunov wrote: > On Thu, Jun 11, 2020 at 09:36:08PM +0200, Vladislav Shpilevoy wrote: >> Thanks for the fixes! Seems like you didn't push them. > > Hmm... I pushed into gorcunov/gh-4651-partial-write-2 branch. > https://lists.tarantool.org/pipermail/tarantool-patches/2020-June/017606.html > > If you mean to merge into master branch -- I don't have such rights ;) Aha, so you changed the branch, but didn't say it anywhere. I was looking at the branch you specified in the cover letter. Just a note - better do a force push on the same branch. Having all these v1, v2, v15, does not simplify the review. Even when you mention branch change in one of the emails, still during the active review process with lots of emails this one could be lost, and people would review the old branch accidentally.