From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D4FF8256B0 for ; Tue, 29 Jan 2019 15:42:22 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AutONds8ssTk for ; Tue, 29 Jan 2019 15:42:22 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 95F72255B1 for ; Tue, 29 Jan 2019 15:42:22 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v8 2/6] iproto: move map creation to sql_response_dump() References: <4a5099086f22bb42002678d434d6a4c65fb51547.1547902954.git.imeevma@gmail.com> <20190125160706.GC4898@chai> From: Vladislav Shpilevoy Message-ID: <610c8885-1579-a809-dbf3-773673c599f7@tarantool.org> Date: Tue, 29 Jan 2019 23:42:20 +0300 MIME-Version: 1.0 In-Reply-To: <20190125160706.GC4898@chai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Konstantin Osipov , tarantool-patches@freelists.org Pushed to 2.1. On 25/01/2019 19:07, Konstantin Osipov wrote: > * imeevma@tarantool.org [19/01/19 23:21]: >> Currently, function sql_response_dump() puts data into an already >> created map. Moving the map creation to sql_response_dump() >> simplifies the code and allows us to use sql_response_dump() as >> one of the port_sql methods. > > This patch seems to be trivial, Vlad, please push if you're OK > with it. > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >