From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 510462F2BD for ; Tue, 13 Nov 2018 11:11:28 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SWrTdNla0pT1 for ; Tue, 13 Nov 2018 11:11:28 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EBF2F2F27C for ; Tue, 13 Nov 2018 11:11:27 -0500 (EST) From: Nikita Pettik Subject: [tarantool-patches] [PATCH v2 2/4] sql: account REPLACE as two row changes Date: Tue, 13 Nov 2018 19:11:21 +0300 Message-Id: <60bebfba861b6378f0bf5de24effba83370a4e7b.1542124689.git.korablev@tarantool.org> In-Reply-To: References: In-Reply-To: References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik In our SQL implementation REPLACE acts as DELETE + INSERT, so we should account it as two row changes. Needed for #2181 --- src/box/sql/insert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c index fd05c0254..a53568810 100644 --- a/src/box/sql/insert.c +++ b/src/box/sql/insert.c @@ -1076,7 +1076,7 @@ process_index: ; sql_triggers_exist(tab, TK_DELETE, NULL, NULL); sql_generate_row_delete(parse_context, tab, trigger, cursor, idx_key_reg, part_count, - false, + true, ON_CONFLICT_ACTION_REPLACE, ONEPASS_SINGLE, -1); sqlite3VdbeResolveLabel(v, skip_index); -- 2.15.1