From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4C65B469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Mar 2020 01:12:51 +0300 (MSK)
References: <cover.1574153367.git.lvasiliev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <6068a76d-c4ae-a848-11fa-4e818e5c6243@tarantool.org>
Date: Wed, 18 Mar 2020 23:12:49 +0100
MIME-Version: 1.0
In-Reply-To: <cover.1574153367.git.lvasiliev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH LUAROCKS v2 0/2] Move a rocks
 options filter from tarantoolctl to luarocks
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid <lvasiliev@tarantool.org>, alexander.turenko@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patchset!

Generally the comments are the same as for the other rocks-related
patchset:

- Add a @ChangeLog;
- Provide a description of the patchset in the cover-letter. What
  was made, how, why?

On 19/11/2019 09:52, Leonid wrote:
> https://github.com/tarantool/tarantool/issues/4629
> https://github.com/tarantool/luarocks/tree/lvasiliev/gh-4629-add-chdir-to-make
> 
> Changes in v2:
> - Move chdir before loading the rockspec file
> 
> Leonid (2):
>   Add the chdir option for make
>   Add the tarantool options black list. Update help
> 
>  src/luarocks/cmd/help.lua | 15 +++++++++------
>  src/luarocks/cmd/make.lua | 22 ++++++++++++++++------
>  src/luarocks/util.lua     | 25 ++++++++++++++++++++-----
>  3 files changed, 45 insertions(+), 17 deletions(-)
>