From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A101B6EFDA; Thu, 2 Jun 2022 16:21:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A101B6EFDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1654176100; bh=eBnS3spiFxdrF2lHOh3Fgx00Zy258L/TizgZjqyLjxE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kz1snRSFVleyUx5E4Ce2swU9OBEdnlCQfkwxd11s7cF600D7hCvjvopuze/PRLuM6 3Je3sCREyEWdPTg3eFbZKi++Qi09ogg31L+iqyi228m86LBZKDKZKKNk0rvfbfyfKC sC0hBD0YHpsjO1B0u+5ShY+/5savFCrahgsTXNxY= Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AAF116EFDA for ; Thu, 2 Jun 2022 16:21:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AAF116EFDA Received: by mail-lf1-f54.google.com with SMTP id t25so7774334lfg.7 for ; Thu, 02 Jun 2022 06:21:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=k6nsd/1U/AHzlCoPq0keNpjXuZcHN5J9jkiKvkO+xT8=; b=T+obaJGQ4Dvh+D6Fzo5OORuPfuYC0Jj/+OajCw0ULPjscod8E/Tu+Vo3ROVBF3jYDy JgJWa15kLOsIfx+SQz0yY74XdH/97KjQRtojHyb5s06nxAzlSlIQf6fzwKA7Ud6bgxP/ 7ZLGdJ8d+GtgIX553k/q3pr/HF1UlZyW3aSp4VboBPsy+s+PZQNiC18fP7GDQebU7j2j r2GiEkrpeRzVX9PzE6ruLJsCJ3BZJ/MxobxRBS+u3bb+9GDgyC86MP9l1zvkFk8dPDm5 yihax9hK5zyM3M7WaTQjrjLKPMKgVcPbbzWy7dHcpowtRn6zjulp38q3aBEEmWrxmXNb ojXQ== X-Gm-Message-State: AOAM531bE9SnAnmkxxMzmTbJFBzUNzehyLkqYtlSnyuFbMX39GRoE3AQ S2Xm9haq+8ALXz6munOpE5vWAfCgW1E= X-Google-Smtp-Source: ABdhPJxCwWabrCwEBAoeMsd+ctmqAY3tArLGG4T+DZyFireK+JXPbkfOA+mrKGy+KyqP0xi0FYv+JA== X-Received: by 2002:ac2:5143:0:b0:478:f1ca:b685 with SMTP id q3-20020ac25143000000b00478f1cab685mr3607427lfd.648.1654176097929; Thu, 02 Jun 2022 06:21:37 -0700 (PDT) Received: from ?IPV6:2a00:1148:b0ba:16:2894:da3a:9c3f:b06? ([2a00:1148:b0ba:16:2894:da3a:9c3f:b06]) by smtp.gmail.com with ESMTPSA id j14-20020a05651231ce00b0047255d211basm1021500lfe.233.2022.06.02.06.21.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 06:21:36 -0700 (PDT) Message-ID: <5fd75a39-fc8f-25c1-a0d5-e84d9f9ffbf2@gmail.com> Date: Thu, 2 Jun 2022 16:21:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Igor Munkin References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH] build: support build using Ninja X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, thanks for your review! I have addressed all issues in patch series v2 (send in a separate thread). Sergey On 26.05.2022 19:21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! I only dump our offline discussion: > * We decided to add a separate CI pipeline to prevent ninja build to be > broken again. It will be run on Linux/x86_64 with no CMake > specification at all (i.e. -DLUAJIT_ENABLE_GC64=OFF and > -DCMAKE_BUILD_TYPE=Release). Added in a separate commit. > * We decided to refactor the targets related to LuaJIT executable, since > ninja forbids using different targets building the same name. Hence > instead of using parameterized dependencies of the fixed targets, > let's use parameterized targets with fixed dependencies (hope it's > not too tricky wording for you). We discussed it at least two times and to avoid conflict by names I have renamed default target and create target for building cli binary only once. > > On 23.05.22, Sergey Bronnikov wrote: >> By default CMake generates files suitable for building a project with >> Make. However, it allows to generate files for Ninja too. Ninja [1] may >> build project a bit faster than Make, see [2]. Patch adds changes >> required for building with Ninja. > Minor: Please, describe these changes in detail. Every change for fixing Ninja build added as a separate commit with a short problem description. > >> How-to build wit Ninja: > Typo: s/wit/with/. Fixed. > >> $ cmake -G Ninja -B build -S . >> $ ninja -C build luajit >> >> On my laptop Ninja reduces building time by 14% (with Make it takes 5.7 >> sec, with Ninja 3.9 sec). It is not so much, but without Ninja support in >> LuaJIT it is not possible to build Tarantool with Ninja. > Minor: This rationale can be moved below (after ---), since I see no > reason to mention particular results in the commit message. The links > below are more than enough. Moved to a cover letter. >> 1. https://ninja-build.org/ >> 2. https://mesonbuild.com/Simple-comparison.html >> --- >> src/CMakeLists.txt | 4 ++-- >> src/host/CMakeLists.txt | 6 ++++-- >> 2 files changed, 6 insertions(+), 4 deletions(-) >> > > >> -- >> 2.25.1 >>