From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 92DBE6C185; Tue, 30 Mar 2021 02:11:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 92DBE6C185 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617059517; bh=hU1jHbuX+JNJ4zfFthYVYxUP7Y7y6i1HHLc4A963SF0=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=v72NwIp7Uddq/OD25sh3dtKjlNfRTQIOReyEBcf5gqezFhgGjJbJ3XZ1AmREzhWvP tOf5AyE8nghTCEyCpHeZmtSybQeTSlaDm1V7pWGTPfWPz5vfL23NRfooeGkXn3Hgpk YENKeUd28CpIGRXEcnbF3jMUaP+0R9UxdRI9WxBU= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9C8986BD02 for ; Tue, 30 Mar 2021 02:07:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9C8986BD02 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lR0yZ-0005EE-Sw; Tue, 30 Mar 2021 02:07:16 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <2fd0811b925fb9bfefa4976ddb48a0799a3914f4.1616491731.git.imeevma@gmail.com> Message-ID: <5e7e6739-6313-207f-e08c-487e2c308e9e@tarantool.org> Date: Tue, 30 Mar 2021 01:07:15 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <2fd0811b925fb9bfefa4976ddb48a0799a3914f4.1616491731.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040A33AF5CB7524B14FBFBA3712E509A31ED1E95016829EA171C2C11DF34C2B58BB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE760302A529BCAAAFCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459434292EC88638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF97BCBEC5B59908DFF1AEEB1321993D68A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C390BCC82C2C62A6D1117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735444A83B712AC0148C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A504E431272EBFF92B8F50ADCAEEE022256950C235509A2DACD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349A949488F6BF46DDF98F253007382005A9FC1113E85B1BE710CC963BF6A5EDED125E2FC05F12152E1D7E09C32AA3244C9D3060B8C29722B64F42C19D89C756DFE8FBBEFAE1C4874CFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rRAI/ZjLsDaZw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822823A09D97FD46AC09BAA12DEE821DB083841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 40/53] sql: move MEM flags to mem.c X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > diff --git a/src/box/sql/mem.h b/src/box/sql/mem.h > index 70224b55a..8b6f6749d 100644 > --- a/src/box/sql/mem.h > +++ b/src/box/sql/mem.h > @@ -563,13 +511,6 @@ columnNullValue(void); > > int sqlVdbeMemTooBig(Mem *); > > -/* Return TRUE if Mem X contains dynamically allocated content - anything > - * that needs to be deallocated to avoid a leak. > - */ > -#define VdbeMemDynamic(X) \ > - (((X)->flags&(MEM_Agg|MEM_Dyn|MEM_Frame))!=0) Why did you remove that? And why don't you have MEM_Agg|MEM_Frame in mem_is_dynamic()?