From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0861723126
	for <tarantool-patches@freelists.org>; Mon, 19 Aug 2019 17:02:13 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 0bdOIUxFU2k0 for <tarantool-patches@freelists.org>;
	Mon, 19 Aug 2019 17:02:12 -0400 (EDT)
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B56B6230EA
	for <tarantool-patches@freelists.org>; Mon, 19 Aug 2019 17:02:12 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 0/2] Introduce WITH ENGINE option for
 CREATE TABLE stmt
References: <cover.1566223966.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <5e4c292d-fd37-78dd-1265-4023029c5ca9@tarantool.org>
Date: Mon, 19 Aug 2019 23:05:05 +0200
MIME-Version: 1.0
In-Reply-To: <cover.1566223966.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>
Cc: kostja@tarantool.org, Kirill Yukhin <kyukhin@tarantool.org>

Thanks for the patch! LGTM.

On 19/08/2019 16:49, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/issues/4422
> Issue: https://github.com/tarantool/tarantool/tree/np/gh-4422-with-engine-option
> 
> See particular commits for details.
> 
> Nikita Pettik (2):
>   Do not log error in engine_find()
>   sql: allow to specify engine in CREATE TABLE stmt
> 
>  extra/mkkeywordhash.c    |  1 +
>  src/box/engine.h         |  4 +--
>  src/box/sql/parse.y      | 27 +++++++++++++--
>  test/sql/engine.result   | 85 ++++++++++++++++++++++++++++++++++++++++++++++++
>  test/sql/engine.test.lua | 30 +++++++++++++++++
>  5 files changed, 141 insertions(+), 6 deletions(-)
>