From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id ED4944696C4
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  1 May 2020 22:35:57 +0300 (MSK)
References: <20200426230900.23258-1-roman.habibov@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <5dd7c06e-0b26-6bcd-a173-23c5e7d7d660@tarantool.org>
Date: Fri, 1 May 2020 21:35:56 +0200
MIME-Version: 1.0
In-Reply-To: <20200426230900.23258-1-roman.habibov@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Name columns in a different
 way
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the patchset!

On 27/04/2020 01:08, Roman Khabibov wrote:
> Should I squash these patches into one patch?

They close different bugs, so I would keep them separate.

> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3962-column
> Issue: https://github.com/tarantool/tarantool/issues/3962
> Issue: https://github.com/tarantool/tarantool/issues/4545
> 
> @ChangeLog:
> - Name auto generated columns as “COLUMN_N” instead of “_auto_name_”
> or span of the original expression.
> - Don't make column names unique by printing "_1" to the end during
> <FROM> processing.

Please, write 'Changes in v<patch_version>' changelog about what
has changed in a major way since previous version of the patch. It
helps a lot, when I return to the patch after a long time.