From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 22797163548C; Thu, 13 Nov 2025 14:06:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 22797163548C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763032000; bh=8KJGPtZ78CR+EjjiLlHbYIhGYNEDgTJZg3GXhRoiyU8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=jlgdOcJzrywQxbaz86RemnTNzaaQvl9elfUDCDLyqYIj5CpFyYpJRBTLt4DUBYJQp ESGAn705GTl8emv/Vo8nIuDjhVnDVawtAchp8bR+/H8Am8JlHyXWxh6HZdWX6sTmcq rFThqmKjU3Q63JMXlORH7HPtLvMF6zOO3FqoHhTo= Received: from send197.i.mail.ru (send197.i.mail.ru [95.163.59.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4343D518B09 for ; Thu, 13 Nov 2025 14:06:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4343D518B09 Received: by exim-smtp-68c8686b96-vlhkh with esmtpa (envelope-from ) id 1vJV9x-000000006O7-0UAO; Thu, 13 Nov 2025 14:06:37 +0300 Content-Type: multipart/alternative; boundary="------------r06RD0yXvM09EgFlGTWzb9xP" Message-ID: <5d871254-9296-4eea-9b85-b636c1f80a7e@tarantool.org> Date: Thu, 13 Nov 2025 14:06:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <3e3085c7a9bcb7d1a185e683c8d774a57cb7816a.1761301736.git.skaplun@tarantool.org> In-Reply-To: <3e3085c7a9bcb7d1a185e683c8d774a57cb7816a.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979CE446CE8475ACDA224F0B248F63F7F7E63F89D2AB7E9AB00894C459B0CD1B916C43AFBA3750F8F2EB5D77EF37489D1863F70CDA5772AD378C695665D9A03C70E54C3044D106D88 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7227E4400968B082FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756660F9C9C5BB81B0087C18E55AAD6939916F9446FE4342A1B97A9A165908C9F3FB389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249D88082464251487476E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8BE31AAB7FF4261FD93AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73589424AA0EF8DE9BAC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A548844B259FCDA0A55002B1117B3ED696DBF65CE93BA04123E20DC3F561CE4150823CB91A9FED034534781492E4B8EEAD2739D626790C8313BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF71799835B704791D46F3B7A8716A50FC2E435D61912A6A0E04AAAAEBD354BD5466971B16C155F0C9D57337E961690FE22344429C3B1E42DC5C23B807FB6C71835F827149B3ED0E62111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW1O9wtpSPfcHg= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B592A23222515C4DC0D3DE06ABAFEAF67052FAE888EB9232FD7B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 05/41] perf: adjust binary-trees in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------r06RD0yXvM09EgFlGTWzb9xP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey! thanks for the patch! On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > The test cases are split by the different types of trees: > 1) stretched tree, > 2) long-lived tree, > 3) several trees with a depth of the power of 2, > 4) iteration over all trees in the third test case. > > The number of items is the number of `ItemCheck()` first-level calls > performed in the payload. > --- > > I'm not sure that we should distinguish different subtests here. > OTOH, how to calculate the amount of items correctly for the whole test > instead? > > perf/LuaJIT-benches/binary-trees.lua | 94 ++++++++++++++++++++++------ > 1 file changed, 76 insertions(+), 18 deletions(-) > > diff --git a/perf/LuaJIT-benches/binary-trees.lua b/perf/LuaJIT-benches/binary-trees.lua > index bf040466..9d4dc7b4 100644 > --- a/perf/LuaJIT-benches/binary-trees.lua > +++ b/perf/LuaJIT-benches/binary-trees.lua > @@ -1,3 +1,4 @@ > +local bench = require("bench").new(arg) > > local function BottomUpTree(item, depth) > if depth > 0 then > @@ -18,30 +19,87 @@ local function ItemCheck(tree) > end > end > > -local N = tonumber(arg and arg[1]) or 0 > +local N = tonumber(arg and arg[1]) or 16 Why 16? > local mindepth = 4 > local maxdepth = mindepth + 2 > if maxdepth < N then maxdepth = N end > > -do > - local stretchdepth = maxdepth + 1 > - local stretchtree = BottomUpTree(0, stretchdepth) > - io.write(string.format("stretch tree of depth %d\t check: %d\n", > - stretchdepth, ItemCheck(stretchtree))) > -end > +local stretchdepth = maxdepth + 1 > + > +bench:add({ > + name = "stretch_depth_" .. tostring(stretchdepth), > + payload = function() > + local stretchtree = BottomUpTree(0, stretchdepth) > + local check = ItemCheck(stretchtree) > + return check > + end, > + items = 1, > + checker = function(check) > + return check == -1 it deserves a comment > + end, > +}) > > -local longlivedtree = BottomUpTree(0, maxdepth) > +-- This tree created once on the setup for the first test. > +local longlivedtree I don't like that we should save a benchmark state in global variables. What if we allow setting a user-defined object that will have a state and this state will be passed to checker/payload functions? > > -for depth=mindepth,maxdepth,2 do > +for depth = mindepth, maxdepth, 2 do > local iterations = 2 ^ (maxdepth - depth + mindepth) > - local check = 0 > - for i=1,iterations do > - check = check + ItemCheck(BottomUpTree(1, depth)) + > - ItemCheck(BottomUpTree(-1, depth)) > - end > - io.write(string.format("%d\t trees of depth %d\t check: %d\n", > - iterations*2, depth, check)) > + local tree_bench > + tree_bench = { > + name = "tree_depth_" .. tostring(depth), > + setup = function() > + if not longlivedtree then > + longlivedtree = BottomUpTree(0, maxdepth) > + end > + tree_bench.items = iterations * 2 > + end, > + checker = function(check) > + return check == -iterations * 2 > + end, > + payload = function() > + local check = 0 > + for i = 1, iterations do > + check = check + ItemCheck(BottomUpTree(1, depth)) + > + ItemCheck(BottomUpTree(-1, depth)) > + end > + return check > + end, > + } > + > +bench:add(tree_bench) > end > > -io.write(string.format("long lived tree of depth %d\t check: %d\n", > - maxdepth, ItemCheck(longlivedtree))) > +bench:add({ > + name = "longlived_depth_" .. tostring(maxdepth), > + payload = function() > + local check = ItemCheck(longlivedtree) > + return check > + end, > + items = 1, > + checker = function(check) > + return check == -1 > + end, > +}) > + > +bench:add({ > + name = "all_in_once", s/all_in_once/all_in_one/? > + payload = function() > + for depth = mindepth, maxdepth, 2 do > + local iterations = 2 ^ (maxdepth - depth + mindepth) > + local tree_bench > + local check = 0 > + for i = 1, iterations do > + check = check + ItemCheck(BottomUpTree(1, depth)) + > + ItemCheck(BottomUpTree(-1, depth)) > + end > + assert(check == -iterations * 2) > + end > + end, > + -- Geometric progression, starting at maxdepth trees with the > + -- corresponding step. > + items = (2 * maxdepth) * (4 ^ ((maxdepth - mindepth) / 2 + 1) - 1) / 3, > + -- Correctness is checked in the payload function. > + skip_check = true, > +}) > + > +bench:run_and_report() --------------r06RD0yXvM09EgFlGTWzb9xP Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey!

thanks for the patch!

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

The test cases are split by the different types of trees:
1) stretched tree,
2) long-lived tree,
3) several trees with a depth of the power of 2,
4) iteration over all trees in the third test case.

The number of items is the number of `ItemCheck()` first-level calls
performed in the payload.
---

I'm not sure that we should distinguish different subtests here.
OTOH, how to calculate the amount of items correctly for the whole test
instead?

 perf/LuaJIT-benches/binary-trees.lua | 94 ++++++++++++++++++++++------
 1 file changed, 76 insertions(+), 18 deletions(-)

diff --git a/perf/LuaJIT-benches/binary-trees.lua b/perf/LuaJIT-benches/binary-trees.lua
index bf040466..9d4dc7b4 100644
--- a/perf/LuaJIT-benches/binary-trees.lua
+++ b/perf/LuaJIT-benches/binary-trees.lua
@@ -1,3 +1,4 @@
+local bench = require("bench").new(arg)
 
 local function BottomUpTree(item, depth)
   if depth > 0 then
@@ -18,30 +19,87 @@ local function ItemCheck(tree)
   end
 end
 
-local N = tonumber(arg and arg[1]) or 0
+local N = tonumber(arg and arg[1]) or 16
Why 16? 
 local mindepth = 4
 local maxdepth = mindepth + 2
 if maxdepth < N then maxdepth = N end
 
-do
-  local stretchdepth = maxdepth + 1
-  local stretchtree = BottomUpTree(0, stretchdepth)
-  io.write(string.format("stretch tree of depth %d\t check: %d\n",
-    stretchdepth, ItemCheck(stretchtree)))
-end
+local stretchdepth = maxdepth + 1
+
+bench:add({
+  name = "stretch_depth_" .. tostring(stretchdepth),
+  payload = function()
+    local stretchtree = BottomUpTree(0, stretchdepth)
+    local check = ItemCheck(stretchtree)
+    return check
+  end,
+  items = 1,
+  checker = function(check)
+    return check == -1
it deserves a comment 
+  end,
+})
 
-local longlivedtree = BottomUpTree(0, maxdepth)
+-- This tree created once on the setup for the first test.
+local longlivedtree

I don't like that we should save a benchmark state in global variables.

What if we allow setting a user-defined object that will have a state

and this state will be passed to checker/payload functions?

 
-for depth=mindepth,maxdepth,2 do
+for depth = mindepth, maxdepth, 2 do
   local iterations = 2 ^ (maxdepth - depth + mindepth)
-  local check = 0
-  for i=1,iterations do
-    check = check + ItemCheck(BottomUpTree(1, depth)) +
-            ItemCheck(BottomUpTree(-1, depth))
-  end
-  io.write(string.format("%d\t trees of depth %d\t check: %d\n",
-    iterations*2, depth, check))
+  local tree_bench
+  tree_bench = {
+    name = "tree_depth_" .. tostring(depth),
+    setup = function()
+      if not longlivedtree then
+        longlivedtree = BottomUpTree(0, maxdepth)
+      end
+      tree_bench.items = iterations * 2
+    end,
+    checker = function(check)
+      return check == -iterations * 2
+    end,
+    payload = function()
+      local check = 0
+      for i = 1, iterations do
+        check = check + ItemCheck(BottomUpTree(1, depth)) +
+                ItemCheck(BottomUpTree(-1, depth))
+      end
+      return check
+    end,
+  }
+
+  bench:add(tree_bench)
 end
 
-io.write(string.format("long lived tree of depth %d\t check: %d\n",
-  maxdepth, ItemCheck(longlivedtree)))
+bench:add({
+  name = "longlived_depth_" .. tostring(maxdepth),
+  payload = function()
+    local check = ItemCheck(longlivedtree)
+    return check
+  end,
+  items = 1,
+  checker = function(check)
+    return check == -1
+  end,
+})
+
+bench:add({
+  name = "all_in_once",
s/all_in_once/all_in_one/?  
+  payload = function()
+    for depth = mindepth, maxdepth, 2 do
+      local iterations = 2 ^ (maxdepth - depth + mindepth)
+      local tree_bench
+      local check = 0
+      for i = 1, iterations do
+        check = check + ItemCheck(BottomUpTree(1, depth)) +
+                ItemCheck(BottomUpTree(-1, depth))
+      end
+      assert(check == -iterations * 2)
+    end
+  end,
+  -- Geometric progression, starting at maxdepth trees with the
+  -- corresponding step.
+  items = (2 * maxdepth) * (4 ^ ((maxdepth - mindepth) / 2 + 1) - 1) / 3,
+  -- Correctness is checked in the payload function.
+  skip_check = true,
+})
+
+bench:run_and_report()
--------------r06RD0yXvM09EgFlGTWzb9xP--