From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D22E99ABE89; Thu, 25 Jan 2024 10:56:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D22E99ABE89 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706169417; bh=pnMJsGNAkuOREybuQIWqbJBCMNmKo7YAatAqsHh02+I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=aa5Atd7esf1DzyvCSMDziL3GTV9D5C4mrZl1MdftQ9KRi/MtQfdFS/H1gLYW4/jfE oltJ/gLtg7qnz7LA9yqHqtyQUAlxWfHd3Z/7+z82hgQxn3dtGxO8o+GWsZi/p+6CTa zipNj80W0Sq101tjDBSG9ppJFrNvLSvv14a32bVA= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [95.163.41.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CB0A59ABE89 for ; Thu, 25 Jan 2024 10:56:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CB0A59ABE89 Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1rSubV-00C8be-3B; Thu, 25 Jan 2024 10:56:54 +0300 Message-ID: <5d373296-90a1-4857-bfb0-3b57f39f428a@tarantool.org> Date: Thu, 25 Jan 2024 10:56:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <20240122110344.5401-1-skaplun@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD96A58C36AA2E996498065D321F2FD018A6594B316AC12F7CA182A05F5380850409796AFB8A3770E7D664D33875D82016CCDBD2FFC27E42B52D1C7C82CF08F8E42 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F6EE1C40B2E8BE15EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E16D8B060A9A23898638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D846B6222CA3D295D49D7A02B2D43F6790117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B103CEA74F0D118906D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3AD0E433DBF1FBFA36E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C1D471462564A2E192E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F890A246B268E114E35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5B27E1CDC3F7AEC8BDBFC865278AE308E1AB777EC901EB9E0F87CCE6106E1FC07E67D4AC08A07B9B07BD21ED50D08CA4DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFFEFF202197215A3D9FDE025CFAE1D58162B5EE3D87E0EF7F4118769C1DDCF702B94BA8791A3044804BEAD515961AA0A7CCCC772E791D6E64F53A8D8CBDB55569E48CAC7CA610320002C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojjPo90oGNxwKkKg876fmV1A== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769A53CD27B4A91464E664D33875D82016C84876E3DC5E244DFEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Simplify handling of instable types in TNEW/TDUP load forwarding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, On 1/23/24 16:22, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > > On 23.01.24, Sergey Bronnikov wrote: >> Hi, Sergey! >> >> thanks for the patch! >> >> Everything is fine, but a have a question - >> >> test reproduces a problem with GC32 only, I couldn't reproduce it with GC64. >> >> Is it expected? As I got it right, the problem is not GC-specific. > Just checked on the current master without ASAN, SYSMALLOC, COVERAGE and > got failed test: > | /home/burii/builds_workspace/luajit/master/test/tarantool-tests/lj-994-instable-types-during-loop-unroll.test.lua ........ Dubious, test returned 1 (wstat 256, > | 0x100) > | Failed 1/3 subtests > | ... > | /home/burii/builds_workspace/luajit/master/src/luajit -e 'print(require"ffi".abi"gc64")' > | true > > Maybe it's affected by Coverage|ASAN flags, I don't know. The problem was due to enabled ASAN. > But still valid test case for GC64 build. > >> >> Used CMake options: >> >> >> CMAKE_BUILD_TYPE="Debug" >> CMAKE_C_COMPILER="clang" >> CMAKE_EXPORT_COMPILE_COMMANDS:BOOL="TRUE" >> LUAJIT_ENABLE_COVERAGE:BOOL="TRUE" >> LUAJIT_ENABLE_GC64:BOOL="TRUE" >> LUAJIT_USE_ASAN:BOOL="TRUE" >> LUAJIT_USE_SYSMALLOC:BOOL="TRUE" >> LUA_USE_APICHECK:BOOL="TRUE" >>   LUA_USE_ASSERT:BOOL="TRUE" >> >> >> Sergey >>