From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH 0/4] Outdate disconnected session References: <20181207173541.GB840@chai> From: Vladislav Shpilevoy Message-ID: <5c514703-945c-f34c-0100-a256d0ec23f0@tarantool.org> Date: Tue, 11 Dec 2018 19:12:37 +0300 MIME-Version: 1.0 In-Reply-To: <20181207173541.GB840@chai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: tarantool-patches@freelists.org, Konstantin Osipov Cc: vdavydov.dev@gmail.com List-ID: On 07/12/2018 20:35, Konstantin Osipov wrote: > * Vladislav Shpilevoy [18/12/07 18:48]: >> Once a connection is closed, a long-running user request can not >> learn about this occasion. Even box.sesion.push() still works and >> on_disconnect triggers are not run. >> >> This patch makes things simpler: >> >> * disconnected session is marked as dead. So a user can determine >> if a connection is closed by looking at session type == 'dead', >> or checking for errors from box.session.push(); > > 'dead' is not a session type, it's session state. Please add a > separate method for this purpose, and not abuse the type. Done. See v2. >> >> * on_disconnect triggers are run right after disconnect. Even if >> there are some active requests. > > This is an incompatible change. But people have been actually > complaining in the chat that disconnect triggers are only run > after all messages are processed. So a good one. > >