From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BC95C276F7 for ; Tue, 17 Jul 2018 10:08:35 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 746C__kZGm7V for ; Tue, 17 Jul 2018 10:08:35 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0101526FD8 for ; Tue, 17 Jul 2018 10:08:34 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 4/4] sql: get rid of Column structure References: <4f4e7934d0eac2f295adadb1e5572f8ff4dbf752.1531743627.git.kshcherbatov@tarantool.org> <69de35d4-3e7d-6f9f-8181-05b06c577e6b@tarantool.org> <9b1796b0-744a-4cc2-1011-9e6a091a6e90@tarantool.org> <5a90417c-f742-7a07-dc3d-a3a0646ec05f@tarantool.org> From: Kirill Shcherbatov Message-ID: <5c05ec08-b32b-0ddb-f87e-25d86145ea9f@tarantool.org> Date: Tue, 17 Jul 2018 17:08:32 +0300 MIME-Version: 1.0 In-Reply-To: <5a90417c-f742-7a07-dc3d-a3a0646ec05f@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Vladislav Shpilevoy Hi. I've rebased my this branch on actual 2.0 with Ivan's Index refactoring. On 17.07.2018 12:32, Vladislav Shpilevoy wrote: > Hello. Thanks for the patch! But it again is raw. You skipped > field_def.coll initialization for non-sql code, alter.cc etc. It was a single place in alter.cc in field_def_decode, if I have correctly understood you: struct coll_id *collation = coll_by_id(field->coll_id); if (collation != NULL) field->coll = collation->coll; (I've grepped where coll_id is used)