From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 53DFF6FF801; Sun, 26 Nov 2023 18:14:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 53DFF6FF801 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1701011667; bh=sSxgNK5v4UlLPeN+4+YS/aqIyy/a8qu3eK9KYUEwlT0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Q959/8+n/9Jv5neAVN74eUdCMeZJaDD3hDEmNp2gn3fIX7NcE4OkojXcpRyfz+4Ee lH2G8r4aBWkdRlfulwXsULYEEeqrOlOZZ+5BVch60yj3wYhLZ93t+Yr8TXf3sdeoB4 qulgkafetXHdyCAx7CurZpY0AYawpNycFTlTX3D8= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [95.163.41.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 91DF06FF801 for ; Sun, 26 Nov 2023 18:14:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 91DF06FF801 Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1r7Gq2-0057HF-06; Sun, 26 Nov 2023 18:14:26 +0300 Message-ID: <5a33d140-57d1-4124-9b66-80505a7d8d95@tarantool.org> Date: Sun, 26 Nov 2023 18:14:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org References: <20231004125034.64110-1-max.kokryashkin@gmail.com> <20231004125034.64110-3-max.kokryashkin@gmail.com> In-Reply-To: <20231004125034.64110-3-max.kokryashkin@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91D46036009216274820D9D66A1912FE7D4C10816967059BE182A05F538085040A2783BCD1B37A88AD1BD6FE37CF9A2870EADF6BAAEE40FC7EA03ECBB7DCDBF6C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE728F774C865CF4B07EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063767500BC4578134A08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D865B53E5AA206EEFC3BD166D914050C36117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE140C956E756FBB7A07FB45A5F6E725C8D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE364E7220B7C5505929735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CD2DCF9CF1F528DBC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F72BE6798D6036352CE5475246E174218B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5EE862D7348E894876307767D7E2E2A0D4107E9D325393395F87CCE6106E1FC07E67D4AC08A07B9B0457EE4B4996FC546CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF488DDB94B0BA2B5DEE55EB84930EA939FF33D8B7FE8FE37D3AA2109EB9FAB1C8F2D331BABA2AF9052A47D1427BC164A75BE2922E88FBE09E0C4A27DBAF1988C1A74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNlZijCPCuzh/NLMcGAXzuQ== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458ACF6B7675730CD3A02DE838B2B1E4B2B06440C583C1A7557282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 2/2] Fix snapshot PC when linking to BC_JLOOP that was a BC_RET*. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim LGTM with a minor comment On 10/4/23 15:50, Maksim Kokryashkin wrote: > --- /dev/null > +++ b/test/tarantool-tests/lj-624-jloop-snapshot-pc.test.lua > @@ -0,0 +1,84 @@ > +local tap = require('tap') > +local test = tap.test('lj-624-jloop-snapshot-pc'):skipcond({ > + ['Test requires JIT enabled'] = not jit.status(), > +}) > + > +test:plan(1) > +-- XXX: The test case below triggers the assertion that was > +-- added in the patch if tested without the fix itself. It > +-- is hard to create a stable reproducer without turning off > +-- ASLR and VM randomizations, which is not suitable for testing. Probably it would be useful to say it in commit message.