From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 141B043040F
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  1 Sep 2020 15:50:15 +0300 (MSK)
References: <4c64406bcbe4f52629eba5a5c4dc1c9ea0115dea.1598454255.git.sergeyb@tarantool.org>
 <347d6e10-deb8-d349-e1df-033b5075903f@tarantool.org>
 <20200831110642.GB94343@pony.bronevichok.ru>
 <6478b29b-ccee-35c5-665a-628c9e50b0b1@tarantool.org>
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <5a15dbd9-f362-011a-d494-d6ba75e81be7@tarantool.org>
Date: Tue, 1 Sep 2020 15:50:15 +0300
MIME-Version: 1.0
In-Reply-To: <6478b29b-ccee-35c5-665a-628c9e50b0b1@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH v1] replication: change space sync
	mode in a loop
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Hi, thanks for review!

On 01.09.2020 15:25, Serge Petrenko wrote:
>> I have rewrote tests to consider to cases:
>> - positive, when we have achievable quorum, set mode to sync or async 
>> on a master
>> and then make an insert. Expected successful writes always.
>> - negative, when we change mode to sync or async with tx's in a limbo.
>>
>> So comment above is not relevant now.
>
> Hi! Thanks for the fixes.
>
> The negative case seems pointless, since the change won't happen until 
> the limbo
> gets emptied out. This is because alter{is_sync=...} is a DML 
> operation which
> replaces an entry in _space system space, so it gets stuck on a 
> non-empty limbo,
> just like any DML op.

Yes, I had doubts regarding this testcase despite I know about such 
behavior.

> I suggest you remove it altogether.

Well, negative testcase removed.


>
> Other than that LGTM.
>
>