From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DBEE22DE23
	for <tarantool-patches@freelists.org>; Sat, 25 May 2019 11:46:37 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id XuCEp5B586_h for <tarantool-patches@freelists.org>;
	Sat, 25 May 2019 11:46:37 -0400 (EDT)
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9DD5A28C46
	for <tarantool-patches@freelists.org>; Sat, 25 May 2019 11:46:37 -0400 (EDT)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: [tarantool-patches] Re: [PATCH v1 20/21] sql: replace rc by
 is_aborted in struct Parse
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <8c0e8883707211ef5db388c6a4826ec4764f8fbd.1558780708.git.imeevma@gmail.com>
Date: Sat, 25 May 2019 18:46:34 +0300
Content-Transfer-Encoding: 7bit
Message-Id: <5D7AD1A8-C437-4608-AE09-A8A9E29625EA@tarantool.org>
References: <cover.1558780708.git.imeevma@gmail.com>
 <8c0e8883707211ef5db388c6a4826ec4764f8fbd.1558780708.git.imeevma@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>


Not struct Parse, but struct Vdbe.

> diff --git a/src/box/sql/vdbeapi.c b/src/box/sql/vdbeapi.c
> index 1842e26..0a4f45f 100644
> --- a/src/box/sql/vdbeapi.c
> +++ b/src/box/sql/vdbeapi.c
> 
> 
> diff --git a/src/box/sql/vdbeaux.c b/src/box/sql/vdbeaux.c
> index 28b423d..944a8a7 100644
> --- a/src/box/sql/vdbeaux.c
> +++ b/src/box/sql/vdbeaux.c
> 
> @@ -1703,7 +1701,6 @@ sqlVdbeRewind(Vdbe * p)
> 	}
> #endif
> 	p->pc = -1;
> -	p->rc = 0;

Why not setting here is_aborted = false; ?