From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4DACC2E65E
	for <tarantool-patches@freelists.org>; Sun, 19 May 2019 11:16:03 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Uchzs98DRPZ2 for <tarantool-patches@freelists.org>;
	Sun, 19 May 2019 11:16:03 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 098332E3AA
	for <tarantool-patches@freelists.org>; Sun, 19 May 2019 11:16:03 -0400 (EDT)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: [tarantool-patches] Re: [PATCH 4/8] Removes unused functions and
 macros.
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <3123e77f691f33cbb6386397cd62f562592112de.1556553117.git.szudin@tarantool.org>
Date: Sun, 19 May 2019 18:16:01 +0300
Content-Transfer-Encoding: 7bit
Message-Id: <5C5CB9ED-89EF-4F89-969F-CD2E7A51BCF6@tarantool.org>
References: <cover.1556553117.git.szudin@tarantool.org>
 <cover.1556553117.git.szudin@tarantool.org>
 <3123e77f691f33cbb6386397cd62f562592112de.1556553117.git.szudin@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: szudin@tarantool.org


> 
> diff --git a/extra/mkkeywordhash.c b/extra/mkkeywordhash.c
> index 2ad74eddc..ba4932b49 100644
> --- a/extra/mkkeywordhash.c
> +++ b/extra/mkkeywordhash.c
> @@ -60,11 +60,7 @@ struct Keyword {
> #else
> #  define AUTOINCR   0x00000010
> #endif
> -#ifdef SQL_OMIT_CAST
> -#  define CAST       0
> -#else
> #  define CAST       0x00000020
> -#endif
> #ifdef SQL_OMIT_COMPOUND_SELECT
> #  define COMPOUND   0
> #else
> @@ -85,11 +81,7 @@ struct Keyword {
> #define SUBQUERY     0x00001000
> #  define TRIGGER    0x00002000
> #  define VIEW       0x00008000
> -#ifdef SQL_OMIT_CTE
> -#  define CTE        0
> -#else
> #  define CTE        0x00040000
> -#endif
> #  define RESERVED   0x00000001

What about other if-def macros used in mkkeywordhash.c?
SQL_OMIT_AUTOINCREMENT - we always build with autoincement
SQL_OMIT_CONFLICT_CLAUSE - we always build with conflict clauses
SQL_OMIT_PRAGMA - pragmas are always enabled