From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C1CF222B48
	for <tarantool-patches@freelists.org>; Tue, 29 May 2018 07:51:12 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id UVf_bkUmGL2W for <tarantool-patches@freelists.org>;
	Tue, 29 May 2018 07:51:12 -0400 (EDT)
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3FEFF2212B
	for <tarantool-patches@freelists.org>; Tue, 29 May 2018 07:51:11 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH v7 5/7] sql: change
 sqlite3AddCheckConstraint signature
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <d2a54c8e3d7095b67a429608ca36f2d8bd0adda2.1527084287.git.kshcherbatov@tarantool.org>
Date: Tue, 29 May 2018 14:51:04 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <5B54C4CB-55F6-49AB-BECB-1CF679F535F7@tarantool.org>
References: <cover.1527084286.git.kshcherbatov@tarantool.org>
 <cover.1527084286.git.kshcherbatov@tarantool.org>
 <d2a54c8e3d7095b67a429608ca36f2d8bd0adda2.1527084287.git.kshcherbatov@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>

Hello. I have checked out last version on branch.
I can provide only a few codestyle nitpickings.

>--- a/src/box/sql/build.c
>+++ b/src/box/sql/build.c
>@@ -1019,26 +1019,22 @@ sqlite3AddPrimaryKey(Parse * pParse,    /* =
Parsing context */
>        return;
>}
>=20
>-/*
>- * Add a new CHECK constraint to the table currently under =
construction.
>- */
>void
>-sqlite3AddCheckConstraint(Parse * pParse,      /* Parsing context */
>-                         Expr * pCheckExpr     /* The check expression =
*/
>-    )
>+sql_add_check_constraint(Parse *parser, ExprSpan *span)

Lets use =E2=80=98struct=E2=80=99 prefix, as it should be according to =
codestyle.

>+       Table *table =3D parser->pNewTable;

The same.

>+++ b/src/box/sql/sqliteInt.h
>@@ -3504,7 +3504,15 @@ void sqlite3StartTable(Parse *, Token *, int);
> void sqlite3AddColumn(Parse *, Token *, Token *);
> void sqlite3AddNotNull(Parse *, int);
> void sqlite3AddPrimaryKey(Parse *, ExprList *, int, int, enum =
sort_order);
>-void sqlite3AddCheckConstraint(Parse *, Expr *);
>+
>+/**
>+ * Add a new CHECK constraint to the table currently under =
construction.

Out of 66 chars.