From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E6BFB469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 19 Feb 2020 13:31:40 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
From: Serge Petrenko <sergepetrenko@tarantool.org>
In-Reply-To: <20200219101141.GA9945@atlas>
Date: Wed, 19 Feb 2020 13:31:40 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <5AFD65D5-F667-4632-8151-17A123558EDA@tarantool.org>
References: <cover.1582046958.git.sergepetrenko@tarantool.org>
 <257cb279bd1b62ef6ff98aa4fa7226ba1bf3b2d0.1582046958.git.sergepetrenko@tarantool.org>
 <20200218190324.GB20569@atlas>
 <93920A98-9B17-43AB-86C2-494161FC032B@tarantool.org>
 <20200219085254.GB6538@atlas>
 <1C823375-D749-4A76-960D-2B45FD987A80@tarantool.org>
 <20200219090251.GC6538@atlas>
 <249D8BCD-BB40-43A9-B7FF-3A084991C3A1@tarantool.org>
 <20200219101141.GA9945@atlas>
Subject: Re: [Tarantool-patches] [PATCH v3 2/4] recovery: allow to ignore
 rows coming from a certain instance
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org



> 19 =D1=84=D0=B5=D0=B2=D1=80. 2020 =D0=B3., =D0=B2 13:11, Konstantin =
Osipov <kostja.osipov@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB=
(=D0=B0):
>=20
> * Serge Petrenko <sergepetrenko@tarantool.org> [20/02/19 12:36]:
>> I mean taking replica clock from a subscribe request and setting =
replica_clock[replica->id] =3D INT64_MAX.
>> This is done on master in relay_subscribe() called from =
box_process_subscribe(). Then relay recovery is initialized
>> with this vclock making recovery skip rows coming from the replica =
itself.
>=20
> Why is this logic done on master? Why can't you send the right
> vclock from replica?
>=20


Cos this strange vclock will be used to initialize gc consumer,
and this gc consumer will be ordered by that vclock signature,
which will overflow.
Anyway, let me send the patch first. This is the same problem
in both cases,  when the logic you propose works either on master or
on replica side.
--
Serge Petrenko
sergepetrenko@tarantool.org


>=20
> --=20
> Konstantin Osipov, Moscow, Russia