From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 89700469710 for ; Wed, 27 May 2020 15:59:53 +0300 (MSK) From: Oleg Babin References: <20200527111406.145422-1-gorcunov@gmail.com> <20200527111406.145422-11-gorcunov@gmail.com> Message-ID: <59c8124f-84cb-92cc-ed12-66383973188b@tarantool.org> Date: Wed, 27 May 2020 15:59:46 +0300 MIME-Version: 1.0 In-Reply-To: <20200527111406.145422-11-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v3 10/10] test: use direct log module List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Thanks for your patch. I think that there are some cases that should be also covered: - Invalid parameters: log_format/log_level - It's possible to call log.cfg several times with different set of parameters. On 27/05/2020 14:14, Cyrill Gorcunov wrote: > To test if we can setup logging module before the box/cfg{}. > > Part-of #689 > > Signed-off-by: Cyrill Gorcunov > --- > test/app-tap/logger.test.lua | 27 ++++++++++++++++++++++++--- > 1 file changed, 24 insertions(+), 3 deletions(-) > > diff --git a/test/app-tap/logger.test.lua b/test/app-tap/logger.test.lua > index 7bfa06e80..410220494 100755 > --- a/test/app-tap/logger.test.lua > +++ b/test/app-tap/logger.test.lua > @@ -1,23 +1,44 @@ > #!/usr/bin/env tarantool > > local test = require('tap').test('log') > -test:plan(24) > +test:plan(27) > > -- gh-3946: Assertion failure when using log_format() before box.cfg() > local log = require('log') > log.log_format('plain') > > +-- > +-- gh-689: Operate with logger via log module without calling box.cfg{} > +local json = require('json') > +local filename = "1.log" > + > +log.cfg({log=filename, log_format='json', log_level=5}) > +local m = "info message" > + > +local file = io.open(filename) > +while file:read() do > +end > + > +log.info(m) > +local line = file:read() > +local message = json.decode(line) > +file:close() > + > +test:is(type(message), 'table', "(log) json valid in log.info") > +test:is(message.level, "INFO", "(log) check type info") > +test:is(message.message, m, "(log) check message content") > +log.log_format('plain') > + > -- > -- Check that Tarantool creates ADMIN session for #! script > -- > -local filename = "1.log" > local message = "Hello, World!" > box.cfg{ > log=filename, > + log_format='plain', > memtx_memory=107374182, > } > local fio = require('fio') > -local json = require('json') > local fiber = require('fiber') > local file = io.open(filename) > while file:read() do >