From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 482B06C1AE; Tue, 18 May 2021 18:34:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 482B06C1AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1621352062; bh=8eRWMusRIdSnA2sarpjjFFtFzBfMcZ43oXPfTFQzXM0=; h=Date:In-Reply-To:Cc:To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TwXjESgUUP0SJ5FEKiylWxDFEEePw5/yqXoLkGMghRRcu5+V3XpH/1StPbT7SHFBg LAPa6niVNDERQUc4YRhFuoyZ4ExIbotrbd4a66X6mRu4baVhzozqL5uPAgfbHNyZZM HFTeg4jovKrpUdiU0ur3foijkhL2g42gKr5qq0FY= Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 260686C1AE for ; Tue, 18 May 2021 18:34:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 260686C1AE Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1lj1je-0003xD-Uv; Tue, 18 May 2021 18:34:19 +0300 Message-Id: <591454EB-836C-4466-941C-0AE33597ABC6@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_08645603-73B7-409D-B578-1D9B2C6D0CA4" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Tue, 18 May 2021 18:34:17 +0300 In-Reply-To: Cc: tarantool-patches@dev.tarantool.org To: Sergey Kaplun , Igor Munkin References: <72c91a259dd039fc95961992ae06baee820695be.1620072340.git.imun@tarantool.org> <20210517163433.GN3944@tarantool.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9DE668EC9F13225347FAB719C736B9EAF227D0FD6ADEB75B7182A05F5380850408475B63E2C714DEB07C334C14FBB938402EE487D8563AD9783B621EA0271FB53 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE776199E130E4EDC53EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376AFB9B40001E44068638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B240AE8FE8178DFC245F9E3B08A5CDE68A8CCF7685675CC1A7D2E47CDBA5A96583C09775C1D3CA48CFCA5A41EBD8A3A0199FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CA5A41EBD8A3A0199FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16BA91E23F1B6B78B78B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5716F74EF9A9A13F7E8278ED13C89215173790BAB2EFAFED2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342B1F2AD168155B0631C0A1EDBA0B40F49307582474429D22A063AA73CE17DC8A9C791C39FDE8D0F41D7E09C32AA3244CECD1CD0BB85B8EBFB5CA2158A54139B960759606DA2E136AFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojdWksWVKfsTDNZfMMiSIckw== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81E8EC0B7BC683C84F0CA710FD5B0D6282C63CCAB7DD2232124AD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] build: add missing module for jit.dump on ARM64 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" --Apple-Mail=_08645603-73B7-409D-B578-1D9B2C6D0CA4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi!=20 Thanks for the patch! My test run passes: $ ./test-run.py 5983 Statistics: * pass: 1 As for comment on opt.start - I=E2=80=99m not sure if we will ever = change the threshold for optimizations - better to keep it under control and do not rely on a = magic 100 loop counter. But the essence of the test is not clear to me: we just verify that on = the host platform (the one testing is done) jit.dump is operable? I believe it = should be put into original message then - =E2=80=99to enable jit.dump on = ARM64=E2=80=A6' Otherwise - LGTM. Sergos > On 18 May 2021, at 10:14, Sergey Kaplun wrote: >=20 > Igor, >=20 > On 17.05.21, Igor Munkin wrote: >> Oops, sorry guys, but the test seems to be noop for this fix (in = other >> works it's OK even without patch), so I've reimplemented it. Consider >> the description in the test. Diff is below: >=20 > Thanks for update! > Please consider my comments below. >=20 > Side note: Please, rebase your branch to master to make it buildable. >=20 >>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>=20 >> diff --git a/test/app-tap/gh-5983-jit-library-smoke-tests.skipcond = b/test/app-tap/gh-5983-jit-library-smoke-tests.skipcond >> new file mode 100644 >> index 000000000..2a2ec4d97 >> --- /dev/null >> +++ b/test/app-tap/gh-5983-jit-library-smoke-tests.skipcond >> @@ -0,0 +1,7 @@ >> +import platform >> + >> +# Disabled on FreeBSD due to #4819. >> +if platform.system() =3D=3D 'FreeBSD': >> + self.skip =3D 1 >> + >> +# vim: set ft=3Dpython: >> diff --git a/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua = b/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua >> new file mode 100755 >> index 000000000..72caec2f9 >> --- /dev/null >> +++ b/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua >> @@ -0,0 +1,44 @@ >> +#!/usr/bin/env tarantool >> + >> +-- Just check whether all Lua sources related to jit.dump are >> +-- bundled to the binary. Otherwise, jit.dump module raises >> +-- an error that is handled via . >> +-- XXX: pure require for jit.dump doesn't cover all the cases, >> +-- since dis_.lua are loaded at runtime. Furthermore, this >> +-- error is handled by JIT engine, so we can't use for it. >> +-- Hence, simply sniff the output of the test to check that all >> +-- phases of trace compilation are dumped. >> + >> +if #arg =3D=3D 0 then >> + local tap =3D require('tap') >> + local test =3D tap.test('gh-5983-jit-library-smoke-tests') >> + >> + test:plan(1) >> + >> + -- XXX: Shell argument is necessary to differ test case >> + -- from the test runner. >> + local cmd =3D string.gsub(' 2>&1