Hi! Thanks for the patch! My test run passes: $ ./test-run.py 5983 Statistics: * pass: 1 As for comment on opt.start - I’m not sure if we will ever change the threshold for optimizations - better to keep it under control and do not rely on a magic 100 loop counter. But the essence of the test is not clear to me: we just verify that on the host platform (the one testing is done) jit.dump is operable? I believe it should be put into original message then - ’to enable jit.dump on ARM64…' Otherwise - LGTM. Sergos > On 18 May 2021, at 10:14, Sergey Kaplun wrote: > > Igor, > > On 17.05.21, Igor Munkin wrote: >> Oops, sorry guys, but the test seems to be noop for this fix (in other >> works it's OK even without patch), so I've reimplemented it. Consider >> the description in the test. Diff is below: > > Thanks for update! > Please consider my comments below. > > Side note: Please, rebase your branch to master to make it buildable. > >> >> ================================================================================ >> >> diff --git a/test/app-tap/gh-5983-jit-library-smoke-tests.skipcond b/test/app-tap/gh-5983-jit-library-smoke-tests.skipcond >> new file mode 100644 >> index 000000000..2a2ec4d97 >> --- /dev/null >> +++ b/test/app-tap/gh-5983-jit-library-smoke-tests.skipcond >> @@ -0,0 +1,7 @@ >> +import platform >> + >> +# Disabled on FreeBSD due to #4819. >> +if platform.system() == 'FreeBSD': >> + self.skip = 1 >> + >> +# vim: set ft=python: >> diff --git a/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua b/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua >> new file mode 100755 >> index 000000000..72caec2f9 >> --- /dev/null >> +++ b/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua >> @@ -0,0 +1,44 @@ >> +#!/usr/bin/env tarantool >> + >> +-- Just check whether all Lua sources related to jit.dump are >> +-- bundled to the binary. Otherwise, jit.dump module raises >> +-- an error that is handled via . >> +-- XXX: pure require for jit.dump doesn't cover all the cases, >> +-- since dis_.lua are loaded at runtime. Furthermore, this >> +-- error is handled by JIT engine, so we can't use for it. >> +-- Hence, simply sniff the output of the test to check that all >> +-- phases of trace compilation are dumped. >> + >> +if #arg == 0 then >> + local tap = require('tap') >> + local test = tap.test('gh-5983-jit-library-smoke-tests') >> + >> + test:plan(1) >> + >> + -- XXX: Shell argument is necessary to differ test case >> + -- from the test runner. >> + local cmd = string.gsub(' 2>&1