From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v19 2/3] qsync: order access to the limbo terms
Date: Fri, 1 Oct 2021 15:37:18 +0300 [thread overview]
Message-ID: <590f764f-57f1-eeaf-925c-263c29121fd5@tarantool.org> (raw)
In-Reply-To: <YVb/shiDzv48qAqr@grain>
01.10.2021 15:31, Cyrill Gorcunov пишет:
> On Fri, Oct 01, 2021 at 03:14:52PM +0300, Serge Petrenko wrote:
> ...
>>> +/** Process a synchronous replication request. */
>>> void
>>> txn_limbo_process(struct txn_limbo *limbo, const struct synchro_request *req);
>> Thanks for the patch!
>>
>> Mostly ok with one question:
>>
>> What about txn_limbo_write_confirm/txn_limbo_read_confirm pairs issued
>> inside txn_limbo_ack() and txn_limbo_on_parameters_change() ?
>>
>> Shouldn't they take the latch as well? I mean, txn_limbo_ack() and
>> txn_limbo_on_parameters_change() as a whole.
> Wait, Serge, currently we guard promote_map/max_term, so it won't be
> read while there is its update on the fly. Thus If only I'm not missing
> something obvious txn_limbo_on_parameters_change() can't interfere with
> promote data or race with it anyhow. If you mean some other race then
> it seems I don't see it yet, but I suspect I might be simply wrong :)
Shouldn't we guard limbo->owner as well?
Otherwise you may start writing confirm for an old leader once promote
for a new
one is already in progress.
I don't remember us discussing this before, so, maybe I'm just confused.
--
Serge Petrenko
next prev parent reply other threads:[~2021-10-01 12:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 9:44 [Tarantool-patches] [PATCH v19 0/3] qsync: implement packet filtering (part 1) Cyrill Gorcunov via Tarantool-patches
2021-09-30 9:44 ` [Tarantool-patches] [PATCH v19 1/3] latch: add latch_is_locked helper Cyrill Gorcunov via Tarantool-patches
2021-09-30 9:44 ` [Tarantool-patches] [PATCH v19 2/3] qsync: order access to the limbo terms Cyrill Gorcunov via Tarantool-patches
2021-10-01 12:14 ` Serge Petrenko via Tarantool-patches
2021-10-01 12:31 ` Cyrill Gorcunov via Tarantool-patches
2021-10-01 12:37 ` Serge Petrenko via Tarantool-patches [this message]
2021-10-04 21:53 ` Cyrill Gorcunov via Tarantool-patches
2021-10-05 13:25 ` Serge Petrenko via Tarantool-patches
2021-10-05 21:52 ` Cyrill Gorcunov via Tarantool-patches
2021-09-30 9:44 ` [Tarantool-patches] [PATCH v19 3/3] test: add gh-6036-qsync-order test Cyrill Gorcunov via Tarantool-patches
2021-10-01 12:30 ` Serge Petrenko via Tarantool-patches
2021-10-04 21:16 ` Cyrill Gorcunov via Tarantool-patches
2021-10-05 13:55 ` Serge Petrenko via Tarantool-patches
2021-10-05 22:26 ` Cyrill Gorcunov via Tarantool-patches
2021-10-05 22:32 ` Cyrill Gorcunov via Tarantool-patches
2021-10-06 7:06 ` Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590f764f-57f1-eeaf-925c-263c29121fd5@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v19 2/3] qsync: order access to the limbo terms' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox