From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 10C54576045; Wed, 9 Aug 2023 17:41:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 10C54576045 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1691592077; bh=pBfznNOqQXuZJ26zjSVKbAzuyILYtmgv6J/3+inn9ns=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=lxAHQ8v+okvwri5THExk/bB7xYQvH5c9zh6CxrXKvJkYkIa5ns0TEpkpF27qDhZEq Sj6jd6g2QpCrXmEkBFUoMaYx3MWZ9AhRLEMoJA6CQRxgLWn6QGotpw2L6ZI0AKZC5Q nvVZIAuAfPjITYwmtmAJgu2zZ7QPvlrfmzrtivgk= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [95.163.41.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CE2D856CD18 for ; Wed, 9 Aug 2023 17:41:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CE2D856CD18 Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1qTkN8-00AV0a-2i; Wed, 09 Aug 2023 17:41:15 +0300 Message-ID: <58f7cbd2-8a75-c300-479e-d274e80a0dbc@tarantool.org> Date: Wed, 9 Aug 2023 17:41:12 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun , Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC804E38A5F9341E5D8C5E4A5EF3DB2E749182A05F53808504051F0788D0D4E7210FA0EAA3D6AADFF5B05F6A63C908E7D1C123A0B3AF2081EAE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE741A8F2705CF52F55EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D08E1E5B2BD3D3B78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C59528CE08693A20B12716F3A2361560117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC79B25E177BEFA2CBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B1BDB03A3F2A65D472D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE34E7D9683544204AF03F1AB874ED89028C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407978DA827A17800CE7649B83402744A6742DBA43225CD8A89FB26E97DCB74E6252C6EABA9B74D0DA47B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A529E41DBE0B4528BBE4AB7E4A925BC1F77DE98A16635393DAF87CCE6106E1FC07E67D4AC08A07B9B01F9513A7CA91E555CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF54931BDD00FAEBF7C796D5BB4D1AAB74F86BC21C32F05F8D617C986C92BE9C2EDDCE95BB4BF576A61529AA6C8ABD04CA7D6833522B44F5ED0DB31667F36D6A2BA74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojUzxoxvtYX2pnc0mAvK3GGA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769A37F34929904791EFA0EAA3D6AADFF5BF43CCAED39DA92F1EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/5][v3] codehealth: fix typos X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! thanks for review On 8/9/23 15:58, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the patch! > It's LGTM, but I found more spellcheck errors in the code in: > > * files, that are maintained by us > | ./src/lj_memprof.c:261: resourses ==> resources > | ./src/lj_memprof.c:390: resourses ==> resources > > * since they are not probably be updated ever in > future: > | ./test/LuaJIT-tests/README.md:46: alot ==> a lot, allot > > * since they are not be updated ever in > future: > | ./test/PUC-Rio-Lua-5.1-tests/api.lua:20: allignment ==> alignment > | ./test/PUC-Rio-Lua-5.1-tests/api.lua:336: acess ==> access > | ./test/PUC-Rio-Lua-5.1-tests/db.lua:564: acessing ==> accessing > | ./test/PUC-Rio-Lua-5.1-tests/gc.lua:311: ressurect ==> resurrect > | ./test/PUC-Rio-Lua-5.1-tests/locals.lua:118: fiels ==> feels, fields, files, phials > | ./test/PUC-Rio-Lua-5.1-tests/math.lua:168: convertions ==> conversions > | ./test/PUC-Rio-Lua-5.1-tests/strings.lua:159: formated ==> formatted > > * -- this is debatable, since this part isn't > maintained by us (we still may apply patches from the upstream). > | ./test/lua-Harness-tests/231-metatable.t:398: heigth ==> height > | ./test/lua-Harness-tests/232-object.t:119: insuficient ==> insufficient > | ./test/lua-Harness-tests/232-object.t:133: insuficient ==> insufficient > | ./test/lua-Harness-tests/232-object.t:93: classe ==> class, classes > | ./test/lua-Harness-tests/241-standalone.t:241: runned ==> ran, run, ruined > | ./test/lua-Harness-tests/242-luac.t:275: endianess ==> endianness > > * : > | ./test/tarantool-tests/lj-350-sload-typecheck.test.lua:2: asembling ==> assembling > | ./test/tarantool-tests/lj-357-arm64-hrefk.test.lua:20: invarinat ==> invariant > | ./test/tarantool-tests/misclib-memprof-lapi.test.lua:2: indepentent ==> independent > > > All fixes applied except typos for lua-Harness. I sent a patch with fixes to maintainer of lua-Harness François Perrad. See the patch below. diff --git a/src/lj_memprof.c b/src/lj_memprof.c index c600c4f0..2e33d88d 100644 --- a/src/lj_memprof.c +++ b/src/lj_memprof.c @@ -258,7 +258,7 @@ int lj_memprof_start(struct lua_State *L, const struct lj_memprof_options *opt)    lua_assert(opt->len != 0);    if (mp->state != MPS_IDLE) { -    /* Clean up resourses. Ignore possible errors. */ +    /* Clean up resources. Ignore possible errors. */      opt->on_stop(opt->ctx, opt->buf);      return PROFILE_ERRRUN;    } @@ -387,7 +387,7 @@ void lj_memprof_add_trace(const struct GCtrace *tr)  int lj_memprof_start(struct lua_State *L, const struct lj_memprof_options *opt)  {    UNUSED(L); -  /* Clean up resourses. Ignore possible errors. */ +  /* Clean up resources. Ignore possible errors. */    opt->on_stop(opt->ctx, opt->buf);    return PROFILE_ERRUSE;  } diff --git a/test/PUC-Rio-Lua-5.1-tests/api.lua b/test/PUC-Rio-Lua-5.1-tests/api.lua index c955ebf9..7ec2f1ba 100644 --- a/test/PUC-Rio-Lua-5.1-tests/api.lua +++ b/test/PUC-Rio-Lua-5.1-tests/api.lua @@ -17,7 +17,7 @@ function pack(...) return arg end  print('testing C API') --- testing allignment +-- testing alignment  a = T.d2s(12458954321123)  assert(string.len(a) == 8)   -- sizeof(double)  assert(T.s2d(a) == 12458954321123) @@ -333,7 +333,7 @@ F = function (x)    if A ~= nil then      assert(type(A) == "userdata")      assert(T.udataval(A) == B) -    debug.getmetatable(A)    -- just acess it +    debug.getmetatable(A)    -- just access it    end    A = x   -- ressucita userdata    B = udval diff --git a/test/PUC-Rio-Lua-5.1-tests/db.lua b/test/PUC-Rio-Lua-5.1-tests/db.lua index b148c2dd..0d4692e1 100644 --- a/test/PUC-Rio-Lua-5.1-tests/db.lua +++ b/test/PUC-Rio-Lua-5.1-tests/db.lua @@ -561,7 +561,7 @@ t[1] = "'error'"  checktraceback(co, t) --- test acessing line numbers of a coroutine from a resume inside +-- test accessing line numbers of a coroutine from a resume inside  -- a C function (this is a known bug in Lua 5.0)  local function g(x) diff --git a/test/PUC-Rio-Lua-5.1-tests/gc.lua b/test/PUC-Rio-Lua-5.1-tests/gc.lua index 10e1f2dd..a1c6e7c7 100644 --- a/test/PUC-Rio-Lua-5.1-tests/gc.lua +++ b/test/PUC-Rio-Lua-5.1-tests/gc.lua @@ -308,7 +308,7 @@ do      assert(getmetatable(o) == tt)      -- create new objects during GC      local a = 'xuxu'..(10+3)..'joao', {} -    ___Glob = o  -- ressurect object! +    ___Glob = o  -- resurrect object!      newproxy(o)  -- creates a new one with same metatable      print(">>> closing state " .. "<<<\n")    end diff --git a/test/PUC-Rio-Lua-5.1-tests/math.lua b/test/PUC-Rio-Lua-5.1-tests/math.lua index f66ce196..63efc5dd 100644 --- a/test/PUC-Rio-Lua-5.1-tests/math.lua +++ b/test/PUC-Rio-Lua-5.1-tests/math.lua @@ -165,7 +165,7 @@ stat(a)  a = nil --- testing implicit convertions +-- testing implicit conversions  local a,b = '10', '20'  assert(a*b == 200 and a+b == 30 and a-b == -10 and a/b == 0.5 and -b == -20) diff --git a/test/PUC-Rio-Lua-5.1-tests/strings.lua b/test/PUC-Rio-Lua-5.1-tests/strings.lua index 3cc1c1b2..0818e390 100644 --- a/test/PUC-Rio-Lua-5.1-tests/strings.lua +++ b/test/PUC-Rio-Lua-5.1-tests/strings.lua @@ -156,7 +156,7 @@ assert(string.format('"-%20s.20s"', string.rep("%", 2000)) ==         string.format("%q", "-"..string.rep("%", 2000)..".20s")) --- longest number that can be formated +-- longest number that can be formatted  assert(string.len(string.format('%99.99f', -1e308)) >= 100)  assert(loadstring("return 1\n--comentário sem EOL no final")() == 1) diff --git a/test/tarantool-tests/lj-350-sload-typecheck.test.lua b/test/tarantool-tests/lj-350-sload-typecheck.test.lua index 33380170..c6876473 100644 --- a/test/tarantool-tests/lj-350-sload-typecheck.test.lua +++ b/test/tarantool-tests/lj-350-sload-typecheck.test.lua @@ -1,5 +1,5 @@  local tap = require('tap') --- Test file to demonstrate the incorrect GC64 JIT asembling +-- Test file to demonstrate the incorrect GC64 JIT assembling  -- `IR_SLOAD`.  -- See also https://github.com/LuaJIT/LuaJIT/pull/350.  local test = tap.test('lj-350-sload-typecheck'):skipcond({ diff --git a/test/tarantool-tests/lj-357-arm64-hrefk.test.lua b/test/tarantool-tests/lj-357-arm64-hrefk.test.lua index 8db8bbfc..23e06d8c 100644 --- a/test/tarantool-tests/lj-357-arm64-hrefk.test.lua +++ b/test/tarantool-tests/lj-357-arm64-hrefk.test.lua @@ -17,7 +17,7 @@ local t = {hrefk = 0}  -- chooses the same register as a base register for offset and  -- destination in LDR instruction.  -- We need 1028 iterations = 1024 iteration for 10 table rehashing --- (create side traces for invarinat and variant loop part) + +-- (create side traces for invariant and variant loop part) +  -- 3 for trace initialize + 1 to run the bad trace.  local START = 1028  local STOP = 1 diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua index 20cfef21..8132cf08 100644 --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua @@ -1,5 +1,5 @@  -- XXX: This comment is a reminder to reimplement memprof tests --- assertions to make them more indepentent to the changes made. +-- assertions to make them more independent to the changes made.  local tap = require("tap")  local test = tap.test("misc-memprof-lapi"):skipcond({    ['Test requires JIT enabled'] = not jit.status(),